Skip to content

Commit bba4249

Browse files
Format
1 parent b2e7d05 commit bba4249

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

firebase-firestore/src/main/java/com/google/firebase/firestore/local/IndexBackfiller.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,8 @@ private IndexOffset getNewOffset(IndexOffset existingOffset, LocalDocumentsResul
158158
IndexOffset latestOffset = existingOffset;
159159
for (Map.Entry<DocumentKey, Document> entry : lookupResult.getDocuments()) {
160160
IndexOffset newOffset =
161-
IndexOffset.fromDocument(entry.getValue(), lookupResult.getLargestBatchId());
161+
IndexOffset.create(
162+
entry.getValue().getReadTime(), entry.getKey(), lookupResult.getLargestBatchId());
162163
if (newOffset.compareTo(latestOffset) > 0) {
163164
latestOffset = newOffset;
164165
}

firebase-firestore/src/main/java/com/google/firebase/firestore/local/MemoryRemoteDocumentCache.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ public Map<DocumentKey, MutableDocument> getAll(ResourcePath collection, IndexOf
121121
continue;
122122
}
123123

124-
if (IndexOffset.fromDocument(doc, 0).compareTo(offset) <= 0) {
124+
if (IndexOffset.fromDocument(doc).compareTo(offset) <= 0) {
125125
// The document sorts before the offset.
126126
continue;
127127
}

firebase-firestore/src/test/java/com/google/firebase/firestore/local/IndexingEnabledSQLiteLocalStoreTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ public void testUsesPartialIndexedOverlaysWhenAvailable() {
117117

118118
Query query = query("coll").filter(filter("matches", "==", true));
119119
executeQuery(query);
120-
assertMutationsRead(/* byKey= */ 1, /* byCollection= */ 1);
120+
assertOverlaysRead(/* byKey= */ 1, /* byCollection= */ 1);
121121
assertQueryReturned("coll/a", "coll/b");
122122
}
123123

firebase-firestore/src/test/java/com/google/firebase/firestore/local/LocalStoreTestCase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ private void assertHasNamedQuery(NamedQuery expectedNamedQuery) {
327327
* Asserts the expected numbers of mutations read by the OverlayQueue since the last call to
328328
* `resetPersistenceStats()`.
329329
*/
330-
private void assertOverlaysRead(int byKey, int byCollection) {
330+
protected void assertOverlaysRead(int byKey, int byCollection) {
331331
assertEquals("Overlays read (by key)", byKey, queryEngine.getOverlaysReadByKey());
332332
assertEquals(
333333
"Overlays read (by collection)", byCollection, queryEngine.getOverlaysReadByCollection());

0 commit comments

Comments
 (0)