Skip to content

Commit b6c3465

Browse files
committed
Address Feedback2
1 parent 768f9b3 commit b6c3465

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/FirestoreTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1465,15 +1465,15 @@ public void testCanGetSameOrDifferentPersistentCacheIndexManager() {
14651465
db1.setFirestoreSettings(settings1);
14661466
PersistentCacheIndexManager indexManager1 = db1.getPersistentCacheIndexManager();
14671467
PersistentCacheIndexManager indexManager2 = db1.getPersistentCacheIndexManager();
1468-
assertEquals(indexManager1, indexManager2);
1468+
assertSame(indexManager1, indexManager2);
14691469

14701470
// Use persistent disk cache (default)
14711471
FirebaseFirestore db2 = testFirestore();
14721472
PersistentCacheIndexManager indexManager3 = db2.getPersistentCacheIndexManager();
14731473
PersistentCacheIndexManager indexManager4 = db2.getPersistentCacheIndexManager();
1474-
assertEquals(indexManager3, indexManager4);
1474+
assertSame(indexManager3, indexManager4);
14751475

1476-
assertNotEquals(indexManager1, indexManager3);
1476+
assertNotSame(indexManager1, indexManager3);
14771477

14781478
FirebaseFirestore db3 = testFirestore();
14791479
FirebaseFirestoreSettings settings3 =
@@ -1482,14 +1482,14 @@ public void testCanGetSameOrDifferentPersistentCacheIndexManager() {
14821482
.build();
14831483
db3.setFirestoreSettings(settings3);
14841484
PersistentCacheIndexManager indexManager5 = db3.getPersistentCacheIndexManager();
1485-
assertNotEquals(indexManager1, indexManager5);
1486-
assertNotEquals(indexManager3, indexManager5);
1485+
assertNotSame(indexManager1, indexManager5);
1486+
assertNotSame(indexManager3, indexManager5);
14871487

14881488
// Use persistent disk cache (default)
14891489
FirebaseFirestore db4 = testFirestore();
14901490
PersistentCacheIndexManager indexManager6 = db4.getPersistentCacheIndexManager();
1491-
assertNotEquals(indexManager1, indexManager6);
1492-
assertNotEquals(indexManager3, indexManager6);
1493-
assertNotEquals(indexManager5, indexManager6);
1491+
assertNotSame(indexManager1, indexManager6);
1492+
assertNotSame(indexManager3, indexManager6);
1493+
assertNotSame(indexManager5, indexManager6);
14941494
}
14951495
}

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/IndexingTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,4 +192,6 @@ public void testAutoIndexCreationAfterFailsTermination() {
192192
() -> db.getPersistentCacheIndexManager().deleteAllIndexes(),
193193
"The client has already been terminated");
194194
}
195+
196+
// TODO(b/296100693) Add testing hooks to verify indexes are created as expected.
195197
}

firebase-firestore/src/test/java/com/google/firebase/firestore/local/SQLiteIndexManagerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1191,7 +1191,7 @@ public void testIndexTypeForOrQueries() throws Exception {
11911191
}
11921192

11931193
@Test
1194-
public void TestCreateTargetIndexesCreatesFullIndexesForEachSubTargets() {
1194+
public void TestCreateTargetIndexesCreatesFullIndexesForEachSubTarget() {
11951195
Query query =
11961196
query("coll")
11971197
.filter(orFilters(filter("a", "==", 1), filter("b", "==", 2), filter("c", "==", 3)));

0 commit comments

Comments
 (0)