Make removeSnapshotsInSyncListener run on AQ (#1572)

Brian Chen · web-flow · commit b1172c93cd01 · 2020-05-19T15:50:39.000-07:00
diff --git a/firebase-firestore/src/main/java/com/google/firebase/firestore/core/FirestoreClient.java b/firebase-firestore/src/main/java/com/google/firebase/firestore/core/FirestoreClient.java
@@ -265,10 +265,11 @@ public void addSnapshotsInSyncListener(EventListener<Void> listener) {
   }
 
   public void removeSnapshotsInSyncListener(EventListener<Void> listener) {
+    // Checks for shutdown but does not raise error, allowing remove after shutdown to be a no-op.
     if (isTerminated()) {
       return;
     }
-    eventManager.removeSnapshotsInSyncListener(listener);
+    asyncQueue.enqueueAndForget(() -> eventManager.removeSnapshotsInSyncListener(listener));
   }
 
   private void verifyNotTerminated() {

Original file line number	Diff line number	Diff line change
`@@ -265,10 +265,11 @@ public void addSnapshotsInSyncListener(EventListener<Void> listener) {`
`265`	`265`	`}`
`266`	`266`
`267`	`267`	`public void removeSnapshotsInSyncListener(EventListener<Void> listener) {`
	`268`	`+ // Checks for shutdown but does not raise error, allowing remove after shutdown to be a no-op.`
`268`	`269`	`if (isTerminated()) {`
`269`	`270`	`return;`
`270`	`271`	`}`
`271`		`- eventManager.removeSnapshotsInSyncListener(listener);`
	`272`	`+ asyncQueue.enqueueAndForget(() -> eventManager.removeSnapshotsInSyncListener(listener));`
`272`	`273`	`}`
`273`	`274`
`274`	`275`	`private void verifyNotTerminated() {`