Skip to content

Commit b04b926

Browse files
Maybe test fix? Wish I could run it locally
1 parent 7fe5625 commit b04b926

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

firebase-firestore/src/test/java/com/google/firebase/firestore/local/SQLiteLocalStoreTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ public void testDoesNotUseLimitWhenIndexIsOutdated() {
237237

238238
// The query engine first reads the documents by key and then re-runs the query without limit.
239239
assertRemoteDocumentsRead(/* byKey= */ 5, /* byCollection= */ 0);
240-
assertOverlaysRead(/* byKey= */ 1, /* byCollection= */ 0);
240+
assertOverlaysRead(/* byKey= */ 5, /* byCollection= */ 0);
241241
assertQueryReturned("coll/a", "coll/c");
242242
}
243243

firebase-firestore/src/test/java/com/google/firebase/firestore/local/SQLiteQueryEngineTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import static com.google.firebase.firestore.testutil.TestUtil.fieldIndex;
2424
import static com.google.firebase.firestore.testutil.TestUtil.filter;
2525
import static com.google.firebase.firestore.testutil.TestUtil.map;
26+
import static com.google.firebase.firestore.testutil.TestUtil.orderBy;
2627
import static com.google.firebase.firestore.testutil.TestUtil.patchMutation;
2728
import static com.google.firebase.firestore.testutil.TestUtil.query;
2829
import static com.google.firebase.firestore.testutil.TestUtil.setMutation;
@@ -103,8 +104,7 @@ public void testRefillsIndexedLimitQueries() throws Exception {
103104

104105
addMutation(patchMutation("coll/4", map("a", 5)));
105106

106-
Query query =
107-
query("coll").filter(filter("a", "==", 1)).filter(filter("b", "==", 1)).limitToFirst(3);
107+
Query query = query("coll").orderBy(orderBy("a")).limitToFirst(3);
108108
DocumentSet result = expectOptimizedCollectionScan(() -> runQuery(query, SnapshotVersion.NONE));
109109
assertEquals(docSet(query.comparator(), doc1, doc2, doc4), result);
110110
}

0 commit comments

Comments
 (0)