Skip to content

Commit afb0804

Browse files
committed
Address code review comments
1 parent 3145a71 commit afb0804

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

firebase-perf/src/main/java/com/google/firebase/perf/session/FirebasePerformanceSessionSubscriber.kt

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2024 Google LLC
2+
* Copyright 2025 Google LLC
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -21,13 +21,10 @@ import com.google.firebase.perf.v1.ApplicationProcessState
2121
import com.google.firebase.sessions.api.SessionSubscriber
2222
import java.util.UUID
2323

24-
class FirebasePerformanceSessionSubscriber(private val dataCollectionEnabled: Boolean) :
24+
class FirebasePerformanceSessionSubscriber(override val isDataCollectionEnabled: Boolean) :
2525
SessionSubscriber {
26-
override val isDataCollectionEnabled: Boolean
27-
get() = dataCollectionEnabled
2826

29-
override val sessionSubscriberName: SessionSubscriber.Name
30-
get() = SessionSubscriber.Name.PERFORMANCE
27+
override val sessionSubscriberName: SessionSubscriber.Name = SessionSubscriber.Name.PERFORMANCE
3128

3229
override fun onSessionChanged(sessionDetails: SessionSubscriber.SessionDetails) {
3330
val currentPerfSession = SessionManager.getInstance().perfSession()

firebase-perf/src/main/java/com/google/firebase/perf/session/PerfSession.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,12 @@ public String sessionId() {
6767
}
6868

6969
/** Returns the AQS sessionId for the given session. */
70+
@Nullable
7071
public String aqsSessionId() {
7172
return aqsSessionId;
7273
}
7374

74-
/** Returns the AQS sessionId for the given session. */
75+
/** Sets the AQS sessionId for the given session. */
7576
public void setAQSId(SessionSubscriber.SessionDetails aqs) {
7677
if (aqsSessionId == null) {
7778
aqsSessionId = aqs.getSessionId();

0 commit comments

Comments
 (0)