Skip to content

Commit ad9f13b

Browse files
authored
Fix the smoke tests. (#2242)
- Explicitly depends on annotations to uplift auth's dependency on annotations. - Remove messaging test and fireperf test from the smoke test suite. - Restore messaging test once messaging src in github is up to date. - Restore fireperf test once M85 release is live (#2158).
1 parent e2535c9 commit ad9f13b

File tree

4 files changed

+15
-75
lines changed

4 files changed

+15
-75
lines changed

smoke-tests/build.gradle

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ apply from: "configure.gradle"
6060
dependencies {
6161
// Firebase
6262
implementation "com.google.firebase:firebase-analytics"
63+
implementation "com.google.firebase:firebase-annotations"
6364
implementation "com.google.firebase:firebase-appindexing"
6465
implementation "com.google.firebase:firebase-auth"
6566
implementation "com.google.firebase:firebase-common"
@@ -69,10 +70,11 @@ dependencies {
6970
implementation "com.google.firebase:firebase-firestore"
7071
implementation "com.google.firebase:firebase-functions"
7172
implementation "com.google.firebase:firebase-inappmessaging"
72-
// TODO(yifany): Remove version after messaging is up to date
73-
implementation "com.google.firebase:firebase-messaging:21.0.0"
73+
// TODO(yifany): Restore after messaging in github is up to date
74+
// implementation "com.google.firebase:firebase-messaging"
7475
implementation "com.google.firebase:firebase-ml-vision"
75-
implementation "com.google.firebase:firebase-perf"
76+
// TODO(b/174858514): Restore after M85 release is live
77+
// implementation "com.google.firebase:firebase-perf"
7678
implementation "com.google.firebase:firebase-storage"
7779

7880
// Common utilities (application side)

smoke-tests/src/main/java/com/google/firebase/testing/BuildOnlyTest.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818

1919
import com.google.firebase.appindexing.FirebaseAppIndex;
2020
import com.google.firebase.inappmessaging.FirebaseInAppMessaging;
21-
import com.google.firebase.messaging.FirebaseMessaging;
22-
import com.google.firebase.perf.FirebasePerformance;
21+
// import com.google.firebase.messaging.FirebaseMessaging;
22+
// import com.google.firebase.perf.FirebasePerformance;
2323
import com.google.firebase.ml.vision.FirebaseVision;
2424
import org.junit.Test;
2525
import org.junit.runner.RunWith;
@@ -39,15 +39,15 @@ public void inappmessaging_IsNotNull() {
3939
assertThat(FirebaseInAppMessaging.getInstance()).isNotNull();
4040
}
4141

42-
@Test
43-
public void messaging_IsNotNull() {
44-
assertThat(FirebaseMessaging.getInstance()).isNotNull();
45-
}
42+
// @Test
43+
// public void messaging_IsNotNull() {
44+
// assertThat(FirebaseMessaging.getInstance()).isNotNull();
45+
// }
4646

47-
@Test
48-
public void performance_IsNotNull() {
49-
assertThat(FirebasePerformance.getInstance()).isNotNull();
50-
}
47+
// @Test
48+
// public void performance_IsNotNull() {
49+
// assertThat(FirebasePerformance.getInstance()).isNotNull();
50+
// }
5151

5252
@Test
5353
public void vision_IsNotNull() {

smoke-tests/src/main/java/com/google/firebase/testing/PerformanceMonitoringTest.java

Lines changed: 0 additions & 61 deletions
This file was deleted.

smoke-tests/src/main/java/com/google/firebase/testing/TestSuite.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
DynamicLinksTest.class,
3030
FirestoreTest.class,
3131
FunctionsTest.class,
32-
PerformanceMonitoringTest.class,
3332
RemoteConfigTest.class,
3433
StorageTest.class,
3534
})

0 commit comments

Comments
 (0)