Skip to content

Commit ad7fc61

Browse files
committed
clean up unused function
1 parent 206606d commit ad7fc61

File tree

2 files changed

+4
-19
lines changed

2 files changed

+4
-19
lines changed

firebase-firestore/src/main/java/com/google/firebase/firestore/local/LocalDocumentsView.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -102,14 +102,9 @@ Document getDocument(DocumentKey key) {
102102
* <p>If we don't have cached state for a document in {@code keys}, a NoDocument will be stored
103103
* for that key in the resulting set.
104104
*/
105-
ImmutableSortedMap<DocumentKey, Document> getDocuments(
106-
Iterable<DocumentKey> keys, QueryContext counter) {
107-
Map<DocumentKey, MutableDocument> docs = remoteDocumentCache.getAll(keys, counter);
108-
return getLocalViewOfDocuments(docs, new HashSet<>());
109-
}
110-
111105
ImmutableSortedMap<DocumentKey, Document> getDocuments(Iterable<DocumentKey> keys) {
112-
return getDocuments(keys, new QueryContext());
106+
Map<DocumentKey, MutableDocument> docs = remoteDocumentCache.getAll(keys);
107+
return getLocalViewOfDocuments(docs, new HashSet<>());
113108
}
114109

115110
/**

firebase-firestore/src/main/java/com/google/firebase/firestore/local/QueryEngine.java

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
import static com.google.firebase.firestore.util.Assert.hardAssert;
1818

19-
import androidx.annotation.RestrictTo;
2019
import com.google.firebase.database.collection.ImmutableSortedMap;
2120
import com.google.firebase.database.collection.ImmutableSortedSet;
2221
import com.google.firebase.firestore.core.Query;
@@ -74,11 +73,6 @@ public void initialize(LocalDocumentsView localDocumentsView, IndexManager index
7473
this.initialized = true;
7574
}
7675

77-
@RestrictTo(RestrictTo.Scope.LIBRARY)
78-
public boolean getAutomaticIndexingEnabled() {
79-
return this.automaticIndexingEnabled;
80-
}
81-
8276
public void setAutomaticIndexingEnabled(boolean isEnabled) {
8377
this.automaticIndexingEnabled = isEnabled;
8478
}
@@ -107,6 +101,7 @@ public ImmutableSortedMap<DocumentKey, Document> getDocumentsMatchingQuery(
107101
return result;
108102
}
109103

104+
// TODO(csi): Auto experiment data.
110105
private void CreateCacheIndices(Query query, QueryContext counter, int resultSize) {
111106
if (counter.getDocumentCount() > 2 * resultSize) {
112107
indexManager.createTargetIndices(query.toTarget());
@@ -277,7 +272,7 @@ private ImmutableSortedMap<DocumentKey, Document> executeFullCollectionScan(
277272
* been indexed.
278273
*/
279274
private ImmutableSortedMap<DocumentKey, Document> appendRemainingResults(
280-
Iterable<Document> indexedResults, Query query, IndexOffset offset, QueryContext counter) {
275+
Iterable<Document> indexedResults, Query query, IndexOffset offset) {
281276
// Retrieve all results for documents that were updated since the offset.
282277
ImmutableSortedMap<DocumentKey, Document> remainingResults =
283278
localDocumentsView.getDocumentsMatchingQuery(query, offset);
@@ -286,9 +281,4 @@ private ImmutableSortedMap<DocumentKey, Document> appendRemainingResults(
286281
}
287282
return remainingResults;
288283
}
289-
290-
private ImmutableSortedMap<DocumentKey, Document> appendRemainingResults(
291-
Iterable<Document> indexedResults, Query query, IndexOffset offset) {
292-
return appendRemainingResults(indexedResults, query, offset, new QueryContext());
293-
}
294284
}

0 commit comments

Comments
 (0)