Change 'ignoreNulls' to 'ignoreNullValues'

Author: mrwillis21

encoders/firebase-encoders-json/src/json/java/com/google/firebase/encoders/json/JsonDataEncoderBuilder.java

@@ -44,7 +44,7 @@ public final class JsonDataEncoderBuilder implements EncoderConfig<JsonDataEncod
   private final Map<Class<?>, ObjectEncoder<?>> objectEncoders = new HashMap<>();
   private final Map<Class<?>, ValueEncoder<?>> valueEncoders = new HashMap<>();
   private ObjectEncoder<Object> fallbackEncoder = DEFAULT_FALLBACK_ENCODER;
-  private boolean ignoreNulls = false;
+  private boolean ignoreNullValues = false;
 
   private static final class TimestampEncoder implements ValueEncoder<Date> {
     private static final DateFormat rfc339;
@@ -106,8 +106,8 @@ public JsonDataEncoderBuilder configureWith(@NonNull Configurator config) {
   }
 
   @NonNull
-  public JsonDataEncoderBuilder ignoreNulls(boolean ignore) {
-    this.ignoreNulls = ignore;
+  public JsonDataEncoderBuilder ignoreNullValues(boolean ignore) {
+    this.ignoreNullValues = ignore;
     return this;
   }
 
@@ -119,7 +119,7 @@ public void encode(@NonNull Object o, @NonNull Writer writer)
           throws IOException, EncodingException {
         JsonValueObjectEncoderContext encoderContext =
             new JsonValueObjectEncoderContext(
-                writer, objectEncoders, valueEncoders, fallbackEncoder, ignoreNulls);
+                writer, objectEncoders, valueEncoders, fallbackEncoder, ignoreNullValues);
         encoderContext.add(o, false);
         encoderContext.close();
       }

encoders/firebase-encoders-json/src/json/java/com/google/firebase/encoders/json/JsonValueObjectEncoderContext.java

@@ -49,12 +49,12 @@ JsonValueObjectEncoderContext invoke(@NonNull String name, @Nullable Object o)
       @NonNull Map<Class<?>, ObjectEncoder<?>> objectEncoders,
       @NonNull Map<Class<?>, ValueEncoder<?>> valueEncoders,
       ObjectEncoder<Object> fallbackEncoder,
-      boolean ignoreNulls) {
+      boolean ignoreNullValues) {
     this.jsonWriter = new JsonWriter(writer);
     this.objectEncoders = objectEncoders;
     this.valueEncoders = valueEncoders;
     this.fallbackEncoder = fallbackEncoder;
-    this.addMethod = ignoreNulls ? this::internalAddIgnoreNulls : this::internalAdd;
+    this.addMethod = ignoreNullValues ? this::internalAddIgnoreNullValues : this::internalAdd;
   }
 
   private JsonValueObjectEncoderContext(JsonValueObjectEncoderContext anotherContext) {
@@ -326,7 +326,7 @@ private JsonValueObjectEncoderContext internalAdd(@NonNull String name, @Nullabl
     return add(o, false);
   }
 
-  private JsonValueObjectEncoderContext internalAddIgnoreNulls(
+  private JsonValueObjectEncoderContext internalAddIgnoreNullValues(
       @NonNull String name, @Nullable Object o) throws IOException, EncodingException {
     if (o == null) {
       return this;

encoders/firebase-encoders-json/src/test/java/com/google/firebase/encoders/json/JsonDataEncoderBuilderTests.java

@@ -64,7 +64,7 @@ public void configureWith_shouldCorrectlyRegisterValueEncoder() throws EncodingE
   }
 
   @Test
-  public void ignoreNulls_shouldCorrectlyEncodeObjectIgnoringNullObjects()
+  public void ignoreNullValues_shouldCorrectlyEncodeObjectIgnoringNullObjects()
       throws EncodingException {
     DataEncoder encoder =
         new JsonDataEncoderBuilder()
@@ -76,14 +76,15 @@ public void ignoreNulls_shouldCorrectlyEncodeObjectIgnoringNullObjects()
                           ctx.add("foo", "value");
                           ctx.add("bar", null);
                         }))
-            .ignoreNulls(true)
+            .ignoreNullValues(true)
             .build();
 
     assertThat(encoder.encode(new Foo())).isEqualTo("{\"foo\":\"value\"}");
   }
 
   @Test
-  public void ignoreNulls_shouldCorrectlyEncodeValueIgnoringNullObjects() throws EncodingException {
+  public void ignoreNullValues_shouldCorrectlyEncodeValueIgnoringNullObjects()
+      throws EncodingException {
     DataEncoder encoder =
         new JsonDataEncoderBuilder()
             .configureWith(
@@ -93,7 +94,7 @@ public void ignoreNulls_shouldCorrectlyEncodeValueIgnoringNullObjects() throws E
                         (Foo s, ValueEncoderContext ctx) -> {
                           ctx.add("value");
                         }))
-            .ignoreNulls(true)
+            .ignoreNullValues(true)
             .build();
 
     HashMap<String, Foo> fooMap = new HashMap<>();