Enabled linting for all remaining projects (#67)

ashwinraghav · web-flow · commit 8fe4ee619b84 · 2018-10-09T10:57:11.000-07:00
diff --git a/firebase-database-collection/firebase-database-collection.gradle b/firebase-database-collection/firebase-database-collection.gradle
@@ -17,9 +17,6 @@ apply plugin: 'com.android.library'
 def androidVersion = 26
 
 android {
-    lintOptions {
-        abortOnError false
-    }
     compileSdkVersion androidVersion
 }
 
diff --git a/firebase-database/firebase-database.gradle b/firebase-database/firebase-database.gradle
@@ -38,9 +38,7 @@ android {
         multiDexEnabled true
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
     }
-    lintOptions {
-        abortOnError false
-    }
+
     buildTypes {
         release {
             minifyEnabled false
diff --git a/firebase-storage/firebase-storage.gradle b/firebase-storage/firebase-storage.gradle
@@ -38,8 +38,6 @@ android {
         multiDexEnabled true
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
     }
-    lintOptions {
-    }
 
     buildTypes {
         release {
diff --git a/test-apps/database-test-app/build.gradle b/test-apps/database-test-app/build.gradle
@@ -30,9 +30,6 @@ android {
 
         vectorDrawables.useSupportLibrary true
 
-        lintOptions {
-            tasks.lint.enabled = false
-        }
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
     }
 
diff --git a/test-apps/firestore-test-app/build.gradle b/test-apps/firestore-test-app/build.gradle
@@ -30,9 +30,6 @@ android {
 
         vectorDrawables.useSupportLibrary true
 
-        lintOptions {
-            tasks.lint.enabled = false
-        }
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
     }
 
diff --git a/test-apps/firestore-test-app/lint.xml b/test-apps/firestore-test-app/lint.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<lint>
+    <!--gRPC's DNS name resolver checks for javax.naming at runtime to determine if it can be used, but fails gracefullt without it. This lint error is safe to ignore.-->
+    <!--See : https://github.com/grpc/grpc-java/blob/b0f423295b4674cb5247a6143fd211b050ef0065/core/src/main/java/io/grpc/internal/JndiResourceResolverFactory.java#L73-->
+    <issue id="InvalidPackage">
+        <ignore path="*/io.grpc/grpc-core/*"/>
+    </issue>
+</lint>
diff --git a/test-apps/functions-test-app/build.gradle b/test-apps/functions-test-app/build.gradle
@@ -27,9 +27,6 @@ android {
         versionCode 1
         versionName "1.0"
         testInstrumentationRunner 'android.support.test.runner.AndroidJUnitRunner'
-        lintOptions {
-            tasks.lint.enabled = false
-        }
     }
 
     buildTypes {
diff --git a/test-apps/storage-test-app/build.gradle b/test-apps/storage-test-app/build.gradle
@@ -30,9 +30,6 @@ android {
 
         vectorDrawables.useSupportLibrary true
 
-        lintOptions {
-            tasks.lint.enabled = false
-        }
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
     }
 

Original file line number	Diff line number	Diff line change
`@@ -17,9 +17,6 @@ apply plugin: 'com.android.library'`
`17`	`17`	`def androidVersion = 26`
`18`	`18`
`19`	`19`	`android {`
`20`		`- lintOptions {`
`21`		`- abortOnError false`
`22`		`- }`
`23`	`20`	`compileSdkVersion androidVersion`
`24`	`21`	`}`
`25`	`22`
Original file line number	Diff line number	Diff line change
`@@ -38,8 +38,6 @@ android {`
`38`	`38`	`multiDexEnabled true`
`39`	`39`	`testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"`
`40`	`40`	`}`
`41`		`- lintOptions {`
`42`		`- }`
`43`	`41`
`44`	`42`	`buildTypes {`
`45`	`43`	`release {`
Original file line number	Diff line number	Diff line change
`@@ -30,9 +30,6 @@ android {`
`30`	`30`
`31`	`31`	`vectorDrawables.useSupportLibrary true`
`32`	`32`
`33`		`- lintOptions {`
`34`		`- tasks.lint.enabled = false`
`35`		`- }`
`36`	`33`	`testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"`
`37`	`34`	`}`
`38`	`35`
Original file line number	Diff line number	Diff line change
`@@ -27,9 +27,6 @@ android {`
`27`	`27`	`versionCode 1`
`28`	`28`	`versionName "1.0"`
`29`	`29`	`testInstrumentationRunner 'android.support.test.runner.AndroidJUnitRunner'`
`30`		`- lintOptions {`
`31`		`- tasks.lint.enabled = false`
`32`		`- }`
`33`	`30`	`}`
`34`	`31`
`35`	`32`	`buildTypes {`