Skip to content

Commit 8a7621b

Browse files
VinayGuthalwinay39
andauthored
Fix crashlytics copybara (#5558)
Some of the methods donot have the right nullable annotations. This pr updates all of them --------- Co-authored-by: VinayGuthal <[email protected]>
1 parent 1f531b9 commit 8a7621b

File tree

6 files changed

+14
-2
lines changed

6 files changed

+14
-2
lines changed

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/CrashlyticsCore.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import androidx.annotation.VisibleForTesting;
2323
import com.google.android.gms.tasks.Task;
2424
import com.google.android.gms.tasks.Tasks;
25+
import com.google.errorprone.annotations.CanIgnoreReturnValue;
2526
import com.google.firebase.FirebaseApp;
2627
import com.google.firebase.crashlytics.BuildConfig;
2728
import com.google.firebase.crashlytics.internal.CrashlyticsNativeComponent;
@@ -220,6 +221,7 @@ public boolean onPreExecute(AppData appData, SettingsProvider settingsProvider)
220221
}
221222

222223
/** Performs background initialization asynchronously on the background worker's thread. */
224+
@CanIgnoreReturnValue
223225
public Task<Void> doBackgroundInitializationAsync(SettingsProvider settingsProvider) {
224226
return Utils.callTask(
225227
crashHandlerExecutor,
@@ -232,6 +234,7 @@ public Task<Void> call() throws Exception {
232234
}
233235

234236
/** Performs background initialization synchronously on the calling thread. */
237+
@CanIgnoreReturnValue
235238
private Task<Void> doBackgroundInitialization(SettingsProvider settingsProvider) {
236239
// create the marker for this run
237240
markInitializationStarted();

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/CrashlyticsReportDataCapture.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646
* This class is responsible for capturing information from the system and exception objects,
4747
* parsing them, and returning canonical CrashlyticsReport and Event objects.
4848
*/
49+
@SuppressWarnings("KotlinInternal")
4950
public class CrashlyticsReportDataCapture {
5051

5152
private static final Map<String, Integer> ARCHITECTURES_BY_NAME = new HashMap<>();

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/Utils.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
import com.google.android.gms.tasks.Continuation;
2020
import com.google.android.gms.tasks.Task;
2121
import com.google.android.gms.tasks.TaskCompletionSource;
22+
import com.google.errorprone.annotations.CanIgnoreReturnValue;
23+
2224
import java.util.concurrent.Callable;
2325
import java.util.concurrent.CancellationException;
2426
import java.util.concurrent.CountDownLatch;
@@ -135,6 +137,7 @@ public static <T> T awaitEvenIfOnMainThread(Task<T> task)
135137
}
136138

137139
/** Invokes latch.await(timeout, unit) uninterruptibly. */
140+
@CanIgnoreReturnValue
138141
public static boolean awaitUninterruptibly(CountDownLatch latch, long timeout, TimeUnit unit) {
139142
boolean interrupted = false;
140143
try {

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/metadata/RolloutAssignmentList.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
package com.google.firebase.crashlytics.internal.metadata;
1616

17+
import com.google.errorprone.annotations.CanIgnoreReturnValue;
1718
import com.google.firebase.crashlytics.internal.Logger;
1819
import com.google.firebase.crashlytics.internal.model.CrashlyticsReport;
1920
import java.util.ArrayList;
@@ -38,6 +39,7 @@ public synchronized List<RolloutAssignment> getRolloutAssignmentList() {
3839
return Collections.unmodifiableList(new ArrayList<RolloutAssignment>(rolloutsState));
3940
}
4041

42+
@CanIgnoreReturnValue
4143
public synchronized boolean updateRolloutAssignmentList(List<RolloutAssignment> newMapList) {
4244
rolloutsState.clear();
4345
int nOverLimit = 0;

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/metadata/UserMetadata.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616

1717
import androidx.annotation.Nullable;
1818
import androidx.annotation.VisibleForTesting;
19+
20+
import com.google.errorprone.annotations.CanIgnoreReturnValue;
1921
import com.google.firebase.crashlytics.internal.common.CommonUtils;
2022
import com.google.firebase.crashlytics.internal.common.CrashlyticsBackgroundWorker;
2123
import com.google.firebase.crashlytics.internal.model.CrashlyticsReport;
@@ -180,6 +182,7 @@ public List<CrashlyticsReport.Session.Event.RolloutAssignment> getRolloutsState(
180182
* Update RolloutsState in memory and persistence. Return True if update successfully, false
181183
* otherwise
182184
*/
185+
@CanIgnoreReturnValue
183186
public boolean updateRolloutsState(List<RolloutAssignment> rolloutAssignments) {
184187
synchronized (rolloutsState) {
185188
if (!rolloutsState.updateRolloutAssignmentList(rolloutAssignments)) {

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/model/CrashlyticsReport.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1119,7 +1119,7 @@ public static RolloutsState.Builder builder() {
11191119
public abstract static class Builder {
11201120
@NonNull
11211121
public abstract RolloutsState.Builder setRolloutAssignments(
1122-
@Nullable List<RolloutAssignment> rolloutAssignments);
1122+
@NonNull List<RolloutAssignment> rolloutAssignments);
11231123

11241124
@NonNull
11251125
public abstract RolloutsState build();
@@ -1215,7 +1215,7 @@ public abstract static class Builder {
12151215
@NonNull
12161216
public abstract Builder setLog(@NonNull Log value);
12171217

1218-
@Nullable
1218+
@NonNull
12191219
public abstract Builder setRollouts(@NonNull RolloutsState rolloutsState);
12201220

12211221
@NonNull

0 commit comments

Comments
 (0)