Skip to content

Commit 7aa0173

Browse files
authored
Fix "changed" tasks. (#1539)
* Fix "changed" tasks. Regression introduced during java migration of build logic (#1516). Essentially diff detection is missing required arguments `HEAD@{0} HEAD@{1}` * Fix
1 parent b8c0062 commit 7aa0173

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

buildSrc/src/main/groovy/com/google/firebase/gradle/plugins/ci/AffectedProjectFinder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ Set<Project> find() {
6969
private static Set<String> changedPaths(File workDir) {
7070
try {
7171
Process process =
72-
Runtime.getRuntime().exec("git diff --name-only --submodule=diff", null, workDir);
72+
Runtime.getRuntime().exec("git diff --name-only --submodule=diff HEAD@{0} HEAD@{1}", null, workDir);
7373
process.waitFor();
7474
return ImmutableSet.copyOf(
7575
CharStreams.readLines(new InputStreamReader(process.getInputStream())));

buildSrc/src/main/groovy/com/google/firebase/gradle/plugins/ci/ContinuousIntegrationPlugin.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,9 @@ public void apply(Project project) {
101101
Set<Project> affectedProjects =
102102
new AffectedProjectFinder(project, extension.getIgnorePaths()).find();
103103

104-
setupChangedTask(project, affectedProjects, "checkChanged");
105-
setupChangedTask(project, affectedProjects, "checkCoverageChanged");
106-
setupChangedTask(project, affectedProjects, "deviceCheckChanged");
104+
setupChangedTask(project, affectedProjects, "check");
105+
setupChangedTask(project, affectedProjects, "checkCoverage");
106+
setupChangedTask(project, affectedProjects, "deviceCheck");
107107
}
108108

109109
private static void setupChangedTask(
@@ -114,7 +114,7 @@ private static void setupChangedTask(
114114
check + "Changed",
115115
task -> {
116116
task.setGroup("verification");
117-
task.setDescription("Runs the " + check + " task in all changed projects.");
117+
task.setDescription("Runs the " + check + "Changed task in all changed projects.");
118118
task.setDependsOn(
119119
affectedProjects.stream()
120120
.map(p -> p.getPath() + ":" + check + "Dependents")

0 commit comments

Comments
 (0)