Merge branch 'master' into mila/BloomFilter

milaGGL · milaGGL · commit 79cc9180afae · 2023-03-27T10:06:47.000-07:00
diff --git a/firebase-functions/src/androidTest/backend/functions/package.json b/firebase-functions/src/androidTest/backend/functions/package.json
@@ -7,6 +7,6 @@
   },
   "private": true,
   "engines": {
-    "node": "12"
+    "node": "18"
   }
 }
diff --git a/tools/lint/src/main/kotlin/ProviderAssignmentDetector.kt b/tools/lint/src/main/kotlin/ProviderAssignmentDetector.kt
@@ -40,7 +40,7 @@ class ProviderAssignmentDetector : Detector(), SourceCodeScanner {
     if (!isProviderGet(method)) {
       return
     }
-    val binaryOperation = node.getParentOfType<UBinaryExpression>(true) ?: return
+    val binaryOperation = node.getParentOfType(UBinaryExpression::class.java) ?: return
     if (binaryOperation.operatorIdentifier?.name != "=") return
 
     val assignmentTarget = binaryOperation.leftOperand as? UReferenceExpression ?: return

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ class ProviderAssignmentDetector : Detector(), SourceCodeScanner {`
`40`	`40`	`if (!isProviderGet(method)) {`
`41`	`41`	`return`
`42`	`42`	`}`
`43`		`- val binaryOperation = node.getParentOfType<UBinaryExpression>(true) ?: return`
	`43`	`+ val binaryOperation = node.getParentOfType(UBinaryExpression::class.java) ?: return`
`44`	`44`	`if (binaryOperation.operatorIdentifier?.name != "=") return`
`45`	`45`
`46`	`46`	`val assignmentTarget = binaryOperation.leftOperand as? UReferenceExpression ?: return`