Skip to content

Commit 78e93fb

Browse files
committed
Shortened prefix and capped concatenated string
1 parent bcc60bb commit 78e93fb

File tree

1 file changed

+9
-7
lines changed
  • transport/transport-runtime/src/main/java/com/google/android/datatransport/runtime/logging

1 file changed

+9
-7
lines changed

transport/transport-runtime/src/main/java/com/google/android/datatransport/runtime/logging/Logging.java

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,22 +18,24 @@
1818
import android.util.Log;
1919

2020
public final class Logging {
21+
private static final String prefix = "TRuntime.";
2122
private Logging() {}
2223

2324
private static String getTag(String tag) {
24-
String prefix = "TRuntime.";
25-
return prefix + concatTag(prefix, tag);
25+
if(android.os.Build.VERSION.SDK_INT < Build.VERSION_CODES.N)
26+
return concatTag(prefix, tag);
27+
28+
return prefix + tag;
2629
}
2730

2831
private static String concatTag(String prefix, String tag){
32+
String concatText = prefix + tag;
2933
int loggableLimit = 23;
30-
int remainingSpace = loggableLimit - prefix.length();
3134

32-
if(android.os.Build.VERSION.SDK_INT < Build.VERSION_CODES.N)
33-
if(tag.length() > remainingSpace)
34-
tag = tag.substring(0, remainingSpace);
35+
if(concatText.length() > loggableLimit)
36+
concatText = concatText.substring(0, loggableLimit);
3537

36-
return tag;
38+
return concatText;
3739
}
3840

3941
public static void d(String tag, String message) {

0 commit comments

Comments
 (0)