Skip to content

Commit 5e5caf5

Browse files
committed
Update TODOs
1 parent b3ba68d commit 5e5caf5

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

firebase-perf/src/main/java/com/google/firebase/perf/session/gauges/GaugeManager.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@ private void syncFlush(String sessionId, ApplicationProcessState appState) {
242242
}
243243

244244
// Adding Session ID info.
245+
// TODO(b/394127311): Switch to using AQS.
245246
gaugeMetricBuilder.setSessionId(sessionId);
246247

247248
transportManager.log(gaugeMetricBuilder.build(), appState);
@@ -250,17 +251,16 @@ private void syncFlush(String sessionId, ApplicationProcessState appState) {
250251
/**
251252
* Log the Gauge Metadata information to the transport.
252253
*
253-
* @param sessionId The {@link PerfSession#sessionId()} to which the collected Gauge Metrics
254+
* @param aqsSessionId The {@link PerfSession#aqsSessionId()} ()} to which the collected Gauge Metrics
254255
* should be associated with.
255256
* @param appState The {@link ApplicationProcessState} for which these gauges are collected.
256257
* @return true if GaugeMetadata was logged, false otherwise.
257258
*/
258-
public boolean logGaugeMetadata(String sessionId, ApplicationProcessState appState) {
259-
// TODO(b/394127311): Re-introduce logging of metadata for AQS.
259+
public boolean logGaugeMetadata(String aqsSessionId, ApplicationProcessState appState) {
260260
if (gaugeMetadataManager != null) {
261261
GaugeMetric gaugeMetric =
262262
GaugeMetric.newBuilder()
263-
.setSessionId(sessionId)
263+
.setSessionId(aqsSessionId)
264264
.setGaugeMetadata(getGaugeMetadata())
265265
.build();
266266
transportManager.log(gaugeMetric, appState);

0 commit comments

Comments
 (0)