rollback format checks for AppId and ApiKey, whcih will be added back on next release (#1464)

Author: ChaoqunCHEN

firebase-installations/src/main/java/com/google/firebase/installations/FirebaseInstallations.java

@@ -146,16 +146,6 @@ private void preConditionChecks() {
     Preconditions.checkNotEmpty(getApplicationId());
     Preconditions.checkNotEmpty(getProjectIdentifier());
     Preconditions.checkNotEmpty(getApiKey());
-    Preconditions.checkArgument(
-        Utils.isValidAppIdFormat(getApplicationId()),
-        "Please set your Application ID. A valid Firebase App ID is required to communicate "
-            + "with Firebase server APIs: It identifies your application with Firebase."
-            + "Please refer to https://firebase.google.com/support/privacy/init-options.");
-    Preconditions.checkArgument(
-        Utils.isValidApiKeyFormat(getApiKey()),
-        "Please set a valid API key. A Firebase API key is required to communicate with "
-            + "Firebase server APIs: It authenticates your project with Google."
-            + "Please refer to https://firebase.google.com/support/privacy/init-options.");
   }
 
   /** Returns the Project Id or Project Number for the Firebase Project. */

firebase-installations/src/main/java/com/google/firebase/installations/Utils.java

@@ -15,18 +15,13 @@
 package com.google.firebase.installations;
 
 import android.text.TextUtils;
-import androidx.annotation.NonNull;
 import com.google.firebase.installations.local.PersistedInstallationEntry;
 import java.util.concurrent.TimeUnit;
-import java.util.regex.Pattern; // not using re2j for SDK size considerations
 
 /** Util methods used for {@link FirebaseInstallations} */
 class Utils {
   public static final long AUTH_TOKEN_EXPIRATION_BUFFER_IN_SECS = TimeUnit.HOURS.toSeconds(1);
 
-  private static final String APP_ID_IDENTIFICATION_SUBSTRING = ":";
-  private static final Pattern API_KEY_FORMAT = Pattern.compile("\\AA[\\w-]{38}\\z");
-
   /**
    * Checks if the FIS Auth token is expired or going to expire in next 1 hour {@link
    * #AUTH_TOKEN_EXPIRATION_BUFFER_IN_SECS}.
@@ -46,12 +41,4 @@ public boolean isAuthTokenExpired(PersistedInstallationEntry entry) {
   public long currentTimeInSecs() {
     return TimeUnit.MILLISECONDS.toSeconds(System.currentTimeMillis());
   }
-
-  static boolean isValidAppIdFormat(@NonNull String appId) {
-    return appId.contains(APP_ID_IDENTIFICATION_SUBSTRING);
-  }
-
-  static boolean isValidApiKeyFormat(@NonNull String apiKey) {
-    return API_KEY_FORMAT.matcher(apiKey).matches();
-  }
 }

firebase-installations/src/test/java/com/google/firebase/installations/FirebaseInstallationsTest.java

@@ -966,43 +966,4 @@ public void testDelete_networkError() throws Exception {
           entry.isRegistered());
     }
   }
-
-  @Test
-  public void testAppIdCheck() {
-    // valid appid
-    assertTrue(Utils.isValidAppIdFormat("1:123456789:android:abcdef"));
-    assertTrue(Utils.isValidAppIdFormat("1:515438998704:android:e78ec19738058349"));
-    assertTrue(Utils.isValidAppIdFormat("1:208472424340:android:a243f98a00873753"));
-    assertTrue(Utils.isValidAppIdFormat("1:755541669657:ios:4d6d5a5ce71e9d30"));
-    assertTrue(Utils.isValidAppIdFormat("1:1086610230652:ios:852c7f6ee799ff89"));
-    assertTrue(Utils.isValidAppIdFormat("1:35006771263:web:32b6f4a5b95acd2c"));
-    // invalid appid
-    assertFalse(Utils.isValidAppIdFormat("abc.abc.abc"));
-    assertFalse(
-        Utils.isValidAppIdFormat(
-            "com.google.firebase.samples.messaging.advanced")); // using pakage name as App ID
-  }
-
-  @Test
-  public void testApiKeyCheck() {
-    // valid ApiKey
-    assertTrue(Utils.isValidApiKeyFormat("AIzaSyabcdefghijklmnopqrstuvwxyz1234567"));
-    assertTrue(Utils.isValidApiKeyFormat("AIzaSyA4UrcGxgwQFTfaI3no3t7Lt1sjmdnP5sQ"));
-    assertTrue(Utils.isValidApiKeyFormat("AIzaSyA5_iVawFQ8ABuTZNUdcwERLJv_a_p4wtM"));
-    assertTrue(Utils.isValidApiKeyFormat("AIzaSyANUvH9H9BsUccjsu2pCmEkOPjjaXeDQgY"));
-    assertTrue(Utils.isValidApiKeyFormat("AIzaSyASWm6HmTMdYWpgMnjRBjxcQ9CKctWmLd4"));
-    assertTrue(Utils.isValidApiKeyFormat("AIzaSyAdOS2zB6NCsk1pCdZ4-P6GBdi_UUPwX7c"));
-    assertTrue(Utils.isValidApiKeyFormat("AIzaSyAnLA7NfeLquW1tJFpx_eQCxoX-oo6YyIs"));
-    // invalid ApiKey
-    assertFalse(
-        Utils.isValidApiKeyFormat("BIzaSyabcdefghijklmnopqrstuvwxyz1234567")); // wrong prefix
-    assertFalse(Utils.isValidApiKeyFormat("AIzaSyabcdefghijklmnopqrstuvwxyz")); // wrong length
-    assertFalse(Utils.isValidApiKeyFormat("AIzaSyabcdefghijklmno:qrstuvwxyzabcdefg")); // wrong char
-    assertFalse(Utils.isValidApiKeyFormat("AIzaSyabcdefghijklmno qrstuvwxyzabcdefg")); // wrong char
-    assertFalse(
-        Utils.isValidApiKeyFormat(
-            "AAAAdpB7anM:APA91bFFK03DIT8y3l5uymwbKcUDJdYqTRSP9Qcxg8SU5kKPalEpObdx0C0xv8gQttdWlL"
-                + "W4hLvvHA0JoDKA6Lrvbi-edUjFCPY_WJkuvHxFwGWXjnj4yI4sPQ27mXuSVIyAbgX4aTK0QY"
-                + "pIKq2j1NBi7ZU75gunQg")); // using FCM server key as API key.
-  }
 }