Skip to content

Commit 58c1677

Browse files
authored
Prepare fiam for AGP upgrade. (#4007)
* Remove redundant duplicate symbols * Move TestActivity to proper java package * Cleanup manifests and build files
1 parent a65d648 commit 58c1677

File tree

11 files changed

+6
-53
lines changed

11 files changed

+6
-53
lines changed

firebase-inappmessaging-display/firebase-inappmessaging-display.gradle

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ android {
4343
compileOptions {
4444
sourceCompatibility JavaVersion.VERSION_1_8
4545
targetCompatibility JavaVersion.VERSION_1_8
46-
// Neccesary for Dagger
47-
incremental = false
4846
}
4947

5048
sourceSets {
Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
3-
package="com.google.firebase.inappmessaging.display.internal.bindingwrappers">
3+
package="com.google.firebase.inappmessaging.display.test">
44

55
<application>
66
<uses-library android:name="android.test.runner"/>
@@ -11,9 +11,4 @@
1111
</intent-filter>
1212
</activity>
1313
</application>
14-
15-
<instrumentation
16-
android:name="androidx.test.runner.AndroidJUnitRunner"
17-
android:targetPackage="com.google.firebase.inappmessaging.display.internal.bindingwrappers">
18-
</instrumentation>
1914
</manifest>

firebase-inappmessaging-display/src/androidTest/java/com/google/firebase/inappmessaging/display/internal/bindingwrappers/BannerBindingWrapperTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import androidx.test.runner.AndroidJUnit4;
2828
import com.google.firebase.inappmessaging.display.internal.InAppMessageLayoutConfig;
2929
import com.google.firebase.inappmessaging.display.internal.injection.modules.InflaterConfigModule;
30+
import com.google.firebase.inappmessaging.display.test.TestActivity;
3031
import com.google.firebase.inappmessaging.model.Action;
3132
import java.util.HashMap;
3233
import java.util.Map;

firebase-inappmessaging-display/src/androidTest/java/com/google/firebase/inappmessaging/display/internal/bindingwrappers/CardBindingWrapperTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import androidx.test.runner.AndroidJUnit4;
3636
import com.google.firebase.inappmessaging.display.internal.InAppMessageLayoutConfig;
3737
import com.google.firebase.inappmessaging.display.internal.injection.modules.InflaterConfigModule;
38+
import com.google.firebase.inappmessaging.display.test.TestActivity;
3839
import com.google.firebase.inappmessaging.model.Action;
3940
import com.google.firebase.inappmessaging.model.CardMessage;
4041
import java.util.HashMap;

firebase-inappmessaging-display/src/androidTest/java/com/google/firebase/inappmessaging/display/internal/bindingwrappers/ImageBindingWrapperTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import androidx.test.runner.AndroidJUnit4;
2828
import com.google.firebase.inappmessaging.display.internal.InAppMessageLayoutConfig;
2929
import com.google.firebase.inappmessaging.display.internal.injection.modules.InflaterConfigModule;
30+
import com.google.firebase.inappmessaging.display.test.TestActivity;
3031
import com.google.firebase.inappmessaging.model.Action;
3132
import java.util.HashMap;
3233
import java.util.Map;

firebase-inappmessaging-display/src/androidTest/java/com/google/firebase/inappmessaging/display/internal/bindingwrappers/ModalBindingWrapperTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import androidx.test.runner.AndroidJUnit4;
3535
import com.google.firebase.inappmessaging.display.internal.InAppMessageLayoutConfig;
3636
import com.google.firebase.inappmessaging.display.internal.injection.modules.InflaterConfigModule;
37+
import com.google.firebase.inappmessaging.display.test.TestActivity;
3738
import com.google.firebase.inappmessaging.model.Action;
3839
import com.google.firebase.inappmessaging.model.ModalMessage;
3940
import java.util.HashMap;
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@
1111
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
14-
15-
package com.google.firebase.inappmessaging.display.internal.bindingwrappers;
14+
package com.google.firebase.inappmessaging.display.test;
1615

1716
import android.app.Activity;
1817

firebase-inappmessaging-display/src/main/res/drawable-anydpi-v21/btn_clear.xml

Lines changed: 0 additions & 14 deletions
This file was deleted.

firebase-inappmessaging-display/src/main/res/drawable-anydpi-v21/image_placeholder.xml

Lines changed: 0 additions & 14 deletions
This file was deleted.

firebase-inappmessaging/firebase-inappmessaging.gradle

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@ android {
8585
compileOptions {
8686
sourceCompatibility JavaVersion.VERSION_1_8
8787
targetCompatibility JavaVersion.VERSION_1_8
88-
// Neccesary for Dagger
89-
incremental = false
9088
}
9189
testOptions {
9290
unitTests {
@@ -95,15 +93,6 @@ android {
9593
}
9694
}
9795

98-
configurations.all {
99-
if(it.name.contains('AndroidTestRuntimeClasspath')) {
100-
it.resolutionStrategy {
101-
force 'org.checkerframework:checker-compat-qual:2.5.5'
102-
force 'com.google.guava:guava:30.1.1-android'
103-
}
104-
}
105-
}
106-
10796

10897
thirdPartyLicenses {
10998
add 'Dagger', "${rootDir}/third_party/licenses/apache-2.0.txt"

firebase-inappmessaging/src/androidTest/AndroidManifest.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,4 @@
1414
android:value="com.google.firebase.components.ComponentRegistrar" />
1515
</service>
1616
</application>
17-
18-
<instrumentation
19-
android:name="androidx.test.runner.AndroidJUnitRunner"
20-
android:targetPackage="com.google.firebase.inappmessaging"/>
2117
</manifest>

0 commit comments

Comments
 (0)