Enable thread pool linter check. (#4297)

* Enable thread pool linter check.

All violations are now suppressed, bugs filed to fix each product.

* ktlint

* Remove init

* Fix copyright

Author: vkryachko

appcheck/firebase-appcheck-debug/src/main/java/com/google/firebase/appcheck/debug/internal/DebugAppCheckProvider.java

@@ -16,6 +16,7 @@
 
 import static com.google.android.gms.common.internal.Preconditions.checkNotNull;
 
+import android.annotation.SuppressLint;
 import android.util.Log;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
@@ -45,6 +46,8 @@ public class DebugAppCheckProvider implements AppCheckProvider {
   private final RetryManager retryManager;
   private final Task<String> debugSecretTask;
 
+  // TODO(b/258273630): Migrate to go/firebase-android-executors
+  @SuppressLint("ThreadPoolCreation")
   public DebugAppCheckProvider(@NonNull FirebaseApp firebaseApp, @Nullable String debugSecret) {
     checkNotNull(firebaseApp);
     this.networkClient = new NetworkClient(firebaseApp);

appcheck/firebase-appcheck-playintegrity/src/main/java/com/google/firebase/appcheck/playintegrity/internal/PlayIntegrityAppCheckProvider.java

@@ -14,6 +14,7 @@
 
 package com.google.firebase.appcheck.playintegrity.internal;
 
+import android.annotation.SuppressLint;
 import androidx.annotation.NonNull;
 import androidx.annotation.VisibleForTesting;
 import com.google.android.gms.tasks.Task;
@@ -41,6 +42,8 @@ public class PlayIntegrityAppCheckProvider implements AppCheckProvider {
   private final ExecutorService backgroundExecutor;
   private final RetryManager retryManager;
 
+  // TODO(b/258273630): Migrate to go/firebase-android-executors
+  @SuppressLint("ThreadPoolCreation")
   public PlayIntegrityAppCheckProvider(@NonNull FirebaseApp firebaseApp) {
     this(
         firebaseApp.getOptions().getGcmSenderId(),

appcheck/firebase-appcheck-safetynet/src/main/java/com/google/firebase/appcheck/safetynet/internal/SafetyNetAppCheckProvider.java

@@ -17,6 +17,7 @@
 import static com.google.android.gms.common.internal.Preconditions.checkNotEmpty;
 import static com.google.android.gms.common.internal.Preconditions.checkNotNull;
 
+import android.annotation.SuppressLint;
 import android.content.Context;
 import androidx.annotation.NonNull;
 import androidx.annotation.VisibleForTesting;
@@ -56,6 +57,8 @@ public class SafetyNetAppCheckProvider implements AppCheckProvider {
   private final String apiKey;
 
   /** @param firebaseApp the FirebaseApp to which this Factory is tied. */
+  // TODO(b/258273630): Migrate to go/firebase-android-executors
+  @SuppressLint("ThreadPoolCreation")
   public SafetyNetAppCheckProvider(@NonNull FirebaseApp firebaseApp) {
     this(
         firebaseApp,

appcheck/firebase-appcheck/src/main/java/com/google/firebase/appcheck/internal/DefaultFirebaseAppCheck.java

@@ -16,6 +16,7 @@
 
 import static com.google.android.gms.common.internal.Preconditions.checkNotNull;
 
+import android.annotation.SuppressLint;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.annotation.VisibleForTesting;
@@ -57,6 +58,8 @@ public class DefaultFirebaseAppCheck extends FirebaseAppCheck {
   private AppCheckProvider appCheckProvider;
   private AppCheckToken cachedToken;
 
+  // TODO(b/258273630): Migrate to go/firebase-android-executors
+  @SuppressLint("ThreadPoolCreation")
   public DefaultFirebaseAppCheck(
       @NonNull FirebaseApp firebaseApp,
       @NonNull Provider<HeartBeatController> heartBeatController) {

appcheck/firebase-appcheck/src/main/java/com/google/firebase/appcheck/internal/DefaultTokenRefresher.java

@@ -18,6 +18,7 @@
 import static java.util.concurrent.TimeUnit.MILLISECONDS;
 import static java.util.concurrent.TimeUnit.SECONDS;
 
+import android.annotation.SuppressLint;
 import androidx.annotation.NonNull;
 import androidx.annotation.VisibleForTesting;
 import com.google.android.gms.tasks.OnFailureListener;
@@ -41,6 +42,8 @@ public class DefaultTokenRefresher {
   private volatile ScheduledFuture<?> refreshFuture;
   private volatile long delayAfterFailureSeconds;
 
+  // TODO(b/258273630): Migrate to go/firebase-android-executors
+  @SuppressLint("ThreadPoolCreation")
   DefaultTokenRefresher(@NonNull DefaultFirebaseAppCheck firebaseAppCheck) {
     this(checkNotNull(firebaseAppCheck), Executors.newScheduledThreadPool(/* corePoolSize= */ 1));
   }

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/AabUpdater.java

@@ -19,6 +19,7 @@
 import static com.google.firebase.appdistribution.impl.TaskUtils.runAsyncInTask;
 import static com.google.firebase.appdistribution.impl.TaskUtils.safeSetTaskException;
 
+import android.annotation.SuppressLint;
 import android.app.Activity;
 import android.content.Intent;
 import android.net.Uri;
@@ -52,6 +53,8 @@ class AabUpdater {
   @GuardedBy("updateAabLock")
   private boolean hasBeenSentToPlayForCurrentTask = false;
 
+  // TODO(b/258264924): Migrate to go/firebase-android-executors
+  @SuppressLint("ThreadPoolCreation")
   AabUpdater() {
     this(
         FirebaseAppDistributionLifecycleNotifier.getInstance(),

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/ApkUpdater.java

@@ -19,6 +19,7 @@
 import static com.google.firebase.appdistribution.impl.TaskUtils.safeSetTaskException;
 import static com.google.firebase.appdistribution.impl.TaskUtils.safeSetTaskResult;
 
+import android.annotation.SuppressLint;
 import android.content.Context;
 import android.os.Build.VERSION;
 import android.os.Build.VERSION_CODES;
@@ -62,6 +63,8 @@ class ApkUpdater {
 
   private final Object updateTaskLock = new Object();
 
+  // TODO(b/258264924): Migrate to go/firebase-android-executors
+  @SuppressLint("ThreadPoolCreation")
   public ApkUpdater(@NonNull FirebaseApp firebaseApp, @NonNull ApkInstaller apkInstaller) {
     this(
         Executors.newSingleThreadExecutor(),

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/FirebaseAppDistributionTesterApiClient.java

@@ -16,6 +16,7 @@
 
 import static com.google.firebase.appdistribution.impl.TaskUtils.runAsyncInTask;
 
+import android.annotation.SuppressLint;
 import androidx.annotation.NonNull;
 import com.google.android.gms.tasks.Task;
 import com.google.android.gms.tasks.Tasks;
@@ -63,6 +64,9 @@ private interface FidDependentJob<TResult> {
   private final FirebaseApp firebaseApp;
   private final Provider<FirebaseInstallationsApi> firebaseInstallationsApiProvider;
   private final TesterApiHttpClient testerApiHttpClient;
+
+  // TODO(b/258264924): Migrate to go/firebase-android-executors
+  @SuppressLint("ThreadPoolCreation")
   private final Executor taskExecutor = Executors.newSingleThreadExecutor();
 
   FirebaseAppDistributionTesterApiClient(

firebase-common/src/main/java/com/google/firebase/concurrent/SequentialExecutor.java

@@ -1,3 +1,17 @@
+// Copyright 2022 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
 package com.google.firebase.concurrent;
 
 import static com.google.android.gms.common.internal.Preconditions.checkNotNull;

firebase-config/src/main/java/com/google/firebase/remoteconfig/RemoteConfigComponent.java

@@ -14,6 +14,7 @@
 
 package com.google.firebase.remoteconfig;
 
+import android.annotation.SuppressLint;
 import android.content.Context;
 import android.content.SharedPreferences;
 import androidx.annotation.GuardedBy;
@@ -87,6 +88,8 @@ public class RemoteConfigComponent {
   private Map<String, String> customHeaders = new HashMap<>();
 
   /** Firebase Remote Config Component constructor. */
+  // TODO(b/258275481): Migrate to go/firebase-android-executors
+  @SuppressLint("ThreadPoolCreation")
   RemoteConfigComponent(
       Context context,
       FirebaseApp firebaseApp,
@@ -211,6 +214,8 @@ public synchronized void setCustomHeaders(Map<String, String> customHeaders) {
     this.customHeaders = customHeaders;
   }
 
+  // TODO(b/258275481): Migrate to go/firebase-android-executors
+  @SuppressLint("ThreadPoolCreation")
   private ConfigCacheClient getCacheClient(String namespace, String configStoreType) {
     String fileName =
         String.format(

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/CrashlyticsController.java

@@ -13,6 +13,7 @@
 // limitations under the License.
 package com.google.firebase.crashlytics.internal.common;
 
+import android.annotation.SuppressLint;
 import android.app.ActivityManager;
 import android.app.ApplicationExitInfo;
 import android.content.Context;
@@ -734,6 +735,9 @@ private Task<Void> logAnalyticsAppExceptionEvent(long timestamp) {
       return Tasks.forResult(null);
     }
     Logger.getLogger().d("Logging app exception event to Firebase Analytics");
+
+    // TODO(b/258263226): Migrate to go/firebase-android-executors
+    @SuppressLint("ThreadPoolCreation")
     final ThreadPoolExecutor executor = new ScheduledThreadPoolExecutor(1);
     return Tasks.call(
         executor,

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/ExecutorUtils.java

@@ -16,6 +16,7 @@
 
 import static java.util.concurrent.TimeUnit.SECONDS;
 
+import android.annotation.SuppressLint;
 import com.google.firebase.crashlytics.internal.Logger;
 import java.util.Locale;
 import java.util.concurrent.ExecutorService;
@@ -43,6 +44,8 @@ public static ExecutorService buildSingleThreadExecutorService(String name) {
 
   public static ScheduledExecutorService buildSingleThreadScheduledExecutorService(String name) {
     final ThreadFactory threadFactory = ExecutorUtils.getNamedThreadFactory(name);
+    // TODO(b/258263226): Migrate to go/firebase-android-executors
+    @SuppressLint("ThreadPoolCreation")
     final ScheduledExecutorService executor =
         Executors.newSingleThreadScheduledExecutor(threadFactory);
     ExecutorUtils.addDelayedShutdownHook(name, executor);
@@ -70,6 +73,8 @@ public void onRun() {
     };
   }
 
+  // TODO(b/258263226): Migrate to go/firebase-android-executors
+  @SuppressLint("ThreadPoolCreation")
   private static ExecutorService newSingleThreadExecutor(
       ThreadFactory threadFactory, RejectedExecutionHandler rejectedExecutionHandler) {
     return Executors.unconfigurableExecutorService(
@@ -88,11 +93,14 @@ private static void addDelayedShutdownHook(String serviceName, ExecutorService s
         serviceName, service, DEFAULT_TERMINATION_TIMEOUT, SECONDS);
   }
 
+  // TODO(b/258263226): Migrate to go/firebase-android-executors
+  @SuppressLint("ThreadPoolCreation")
   private static void addDelayedShutdownHook(
       final String serviceName,
       final ExecutorService service,
       final long terminationTimeout,
       final TimeUnit timeUnit) {
+
     Runtime.getRuntime()
         .addShutdownHook(
             new Thread(

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/send/ReportQueue.java

@@ -62,6 +62,8 @@ final class ReportQueue {
         onDemandCounter);
   }
 
+  // TODO(b/258263226): Migrate to go/firebase-android-executors
+  @SuppressLint("ThreadPoolCreation")
   ReportQueue(
       double ratePerMinute,
       double base,
@@ -120,7 +122,8 @@ TaskCompletionSource<CrashlyticsReportWithSessionId> enqueueReport(
     }
   }
 
-  @SuppressLint("DiscouragedApi") // best effort only
+  // TODO(b/258263226): Migrate to go/firebase-android-executors
+  @SuppressLint({"DiscouragedApi", "ThreadPoolCreation"}) // best effort only
   public void flushScheduledReportsIfAble() {
     CountDownLatch latch = new CountDownLatch(1);
     new Thread(

firebase-database/src/main/java/com/google/firebase/database/core/ThreadPoolEventTarget.java

@@ -14,6 +14,7 @@
 
 package com.google.firebase.database.core;
 
+import android.annotation.SuppressLint;
 import java.util.concurrent.BlockingQueue;
 import java.util.concurrent.LinkedBlockingQueue;
 import java.util.concurrent.ThreadFactory;
@@ -25,6 +26,8 @@ class ThreadPoolEventTarget implements EventTarget {
 
   private final ThreadPoolExecutor executor;
 
+  // TODO(b/258277572): Migrate to go/firebase-android-executors
+  @SuppressLint("ThreadPoolCreation")
   public ThreadPoolEventTarget(
       final ThreadFactory wrappedFactory, final ThreadInitializer threadInitializer) {
     int poolSize = 1;

firebase-firestore/src/main/java/com/google/firebase/firestore/core/Transaction.java

@@ -17,6 +17,7 @@
 import static com.google.firebase.firestore.util.Assert.fail;
 import static com.google.firebase.firestore.util.Assert.hardAssert;
 
+import android.annotation.SuppressLint;
 import androidx.annotation.Nullable;
 import com.google.android.gms.tasks.Task;
 import com.google.android.gms.tasks.Tasks;
@@ -162,6 +163,9 @@ private static Executor createDefaultExecutor() {
     int maxPoolSize = corePoolSize;
     int keepAliveSeconds = 1;
     LinkedBlockingQueue<Runnable> queue = new LinkedBlockingQueue<>();
+
+    // TODO(b/258277574): Migrate to go/firebase-android-executors
+    @SuppressLint("ThreadPoolCreation")
     ThreadPoolExecutor executor =
         new ThreadPoolExecutor(
             corePoolSize, maxPoolSize, keepAliveSeconds, TimeUnit.SECONDS, queue);

firebase-firestore/src/main/java/com/google/firebase/firestore/util/AsyncQueue.java

@@ -17,6 +17,7 @@
 import static com.google.firebase.firestore.util.Assert.fail;
 import static com.google.firebase.firestore.util.Assert.hardAssert;
 
+import android.annotation.SuppressLint;
 import android.os.Handler;
 import android.os.Looper;
 import androidx.annotation.NonNull;
@@ -243,6 +244,8 @@ public Thread newThread(@NonNull Runnable runnable) {
       }
     }
 
+    // TODO(b/258277574): Migrate to go/firebase-android-executors
+    @SuppressLint("ThreadPoolCreation")
     SynchronizedShutdownAwareExecutor() {
       DelayedStartFactory threadFactory = new DelayedStartFactory();
 

firebase-inappmessaging/src/main/java/com/google/firebase/inappmessaging/internal/AbtIntegrationHelper.java

@@ -14,6 +14,7 @@
 
 package com.google.firebase.inappmessaging.internal;
 
+import android.annotation.SuppressLint;
 import androidx.annotation.VisibleForTesting;
 import com.google.firebase.abt.AbtException;
 import com.google.firebase.abt.AbtExperimentInfo;
@@ -33,7 +34,10 @@
 public class AbtIntegrationHelper {
   private final FirebaseABTesting abTesting;
 
-  @VisibleForTesting Executor executor = Executors.newSingleThreadExecutor();
+  // TODO(b/258280977): Migrate to go/firebase-android-executors
+  @SuppressLint("ThreadPoolCreation")
+  @VisibleForTesting
+  Executor executor = Executors.newSingleThreadExecutor();
 
   @Inject
   public AbtIntegrationHelper(FirebaseABTesting abTesting) {

firebase-inappmessaging/src/main/java/com/google/firebase/inappmessaging/internal/DeveloperListenerManager.java

@@ -14,6 +14,7 @@
 
 package com.google.firebase.inappmessaging.internal;
 
+import android.annotation.SuppressLint;
 import androidx.annotation.NonNull;
 import com.google.firebase.inappmessaging.FirebaseInAppMessagingClickListener;
 import com.google.firebase.inappmessaging.FirebaseInAppMessagingDismissListener;
@@ -56,6 +57,9 @@ public class DeveloperListenerManager {
       registeredImpressionListeners = new HashMap<>();
 
   private static BlockingQueue<Runnable> mCallbackQueue = new LinkedBlockingQueue<>();
+
+  // TODO(b/258280977): Migrate to go/firebase-android-executors
+  @SuppressLint("ThreadPoolCreation")
   private static final ThreadPoolExecutor CALLBACK_QUEUE_EXECUTOR =
       new ThreadPoolExecutor(
           POOL_SIZE,
@@ -182,6 +186,8 @@ static class FIAMThreadFactory implements ThreadFactory {
 
     @SuppressWarnings("ThreadPriorityCheck")
     @Override
+    // TODO(b/258280977): Migrate to go/firebase-android-executors
+    @SuppressLint("ThreadPoolCreation")
     public Thread newThread(@NonNull Runnable r) {
       Thread t = new Thread(r, "FIAM-" + mNameSuffix + threadNumber.getAndIncrement());
       t.setDaemon(false);

firebase-installations/src/main/java/com/google/firebase/installations/FirebaseInstallations.java

@@ -14,6 +14,7 @@
 
 package com.google.firebase.installations;
 
+import android.annotation.SuppressLint;
 import android.text.TextUtils;
 import androidx.annotation.GuardedBy;
 import androidx.annotation.NonNull;
@@ -96,6 +97,8 @@ public class FirebaseInstallations implements FirebaseInstallationsApi {
         private final AtomicInteger mCount = new AtomicInteger(1);
 
         @Override
+        // TODO(b/258422917): Migrate to go/firebase-android-executors
+        @SuppressLint("ThreadPoolCreation")
         public Thread newThread(Runnable r) {
           return new Thread(
               r, String.format("firebase-installations-executor-%d", mCount.getAndIncrement()));
@@ -123,6 +126,8 @@ public Thread newThread(Runnable r) {
           + "Please retry your last request.";
 
   /** package private constructor. */
+  // TODO(b/258422917): Migrate to go/firebase-android-executors
+  @SuppressLint("ThreadPoolCreation")
   FirebaseInstallations(
       FirebaseApp firebaseApp, @NonNull Provider<HeartBeatController> heartBeatProvider) {
     this(
@@ -142,6 +147,8 @@ public Thread newThread(Runnable r) {
         new RandomFidGenerator());
   }
 
+  // TODO(b/258422917): Migrate to go/firebase-android-executors
+  @SuppressLint("ThreadPoolCreation")
   FirebaseInstallations(
       ExecutorService backgroundExecutor,
       FirebaseApp firebaseApp,