Skip to content

Commit 5695db8

Browse files
committed
Add the pending comment from the previous PR to this branch/PR.
1 parent 316735f commit 5695db8

File tree

1 file changed

+9
-13
lines changed

1 file changed

+9
-13
lines changed

firebase-perf/src/test/java/com/google/firebase/perf/application/FragmentStateMonitorTest.java

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,12 @@
4040
import com.google.firebase.perf.metrics.Trace;
4141
import com.google.firebase.perf.transport.TransportManager;
4242
import com.google.firebase.perf.util.Clock;
43-
import com.google.firebase.perf.util.Constants;
43+
import com.google.firebase.perf.util.Constants.CounterNames;
4444
import com.google.firebase.perf.util.Optional;
4545
import com.google.firebase.perf.util.Timer;
4646
import com.google.firebase.perf.v1.ApplicationProcessState;
4747
import com.google.firebase.perf.v1.TraceMetric;
4848
import java.util.WeakHashMap;
49-
import org.junit.Assert;
5049
import org.junit.Before;
5150
import org.junit.Test;
5251
import org.junit.runner.RunWith;
@@ -116,8 +115,8 @@ public void fragmentTraceName_validFragment_validFragmentScreenTraceNameGenerate
116115
FragmentStateMonitor monitor =
117116
new FragmentStateMonitor(clock, mockTransportManager, appStateMonitor, recorder);
118117
Fragment testFragment = new FragmentMonitorMockFragment();
119-
Assert.assertEquals(
120-
"_st_FragmentMonitorMockFragment", monitor.getFragmentScreenTraceName(testFragment));
118+
assertThat(monitor.getFragmentScreenTraceName(testFragment))
119+
.isEqualTo("_st_FragmentMonitorMockFragment");
121120
}
122121

123122
@Test
@@ -180,15 +179,12 @@ public void lifecycleCallbacks_onPausedCalledBeforeOnResume_doesNotLogFragmentSc
180179
verify(mockTransportManager, times(1))
181180
.log(argTraceMetric.capture(), nullable(ApplicationProcessState.class));
182181
TraceMetric metric = argTraceMetric.getValue();
183-
Assert.assertEquals(
184-
frameCounts1.getTotalFrames(),
185-
(long) metric.getCountersMap().get(Constants.CounterNames.FRAMES_TOTAL.toString()));
186-
Assert.assertEquals(
187-
frameCounts1.getSlowFrames(),
188-
(long) metric.getCountersMap().get(Constants.CounterNames.FRAMES_SLOW.toString()));
189-
Assert.assertEquals(
190-
frameCounts1.getFrozenFrames(),
191-
(long) metric.getCountersMap().get(Constants.CounterNames.FRAMES_FROZEN.toString()));
182+
assertThat((long) metric.getCountersMap().get(CounterNames.FRAMES_TOTAL.toString()))
183+
.isEqualTo(frameCounts1.getTotalFrames());
184+
assertThat((long) metric.getCountersMap().get(CounterNames.FRAMES_SLOW.toString()))
185+
.isEqualTo(frameCounts1.getSlowFrames());
186+
assertThat((long) metric.getCountersMap().get(CounterNames.FRAMES_FROZEN.toString()))
187+
.isEqualTo(frameCounts1.getFrozenFrames());
192188
}
193189

194190
/** Simulate call order of activity + fragment lifecycle events */

0 commit comments

Comments
 (0)