add test coverage

Author: cherylEnkidu

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/IndexingTest.java

@@ -118,7 +118,6 @@ public void testAutoIndexCreationSetSuccessfully() {
             .build();
     db.setFirestoreSettings(settings);
 
-    // Based on current heuristic, collection document counts (3) > 2 * resultSize (1).
     CollectionReference collection =
         testCollectionWithDocs(
             map(
@@ -147,7 +146,6 @@ public void testAutoIndexCreationSetSuccessfullyUsingDefault() {
     // Use persistent disk cache (default)
     FirebaseFirestore db = testFirestore();
 
-    // Based on current heuristic, collection document counts (3) > 2 * resultSize (1).
     CollectionReference collection =
         testCollectionWithDocs(
             map(
@@ -183,5 +181,9 @@ public void testAutoIndexCreationAfterFailsTermination() {
     expectError(
         () -> db.getPersistentCacheIndexManager().disableIndexAutoCreation(),
         "The client has already been terminated");
+
+    expectError(
+        () -> db.getPersistentCacheIndexManager().deleteAllIndexes(),
+        "The client has already been terminated");
   }
 }

firebase-firestore/src/main/java/com/google/firebase/firestore/PersistentCacheIndexManager.java

@@ -54,7 +54,7 @@ public void disableIndexAutoCreation() {
 
   /**
    * Removes all persistent cache indexes. Please note this function will also deletes indexes
-   * generated by {@link FirebaseFirestore#setIndexConfiguration(String)}.
+   * generated by {@link FirebaseFirestore#setIndexConfiguration(String)}, which is deprecated.
    */
   public void deleteAllIndexes() {
     client.deleteAllFieldIndexes();

firebase-firestore/src/test/java/com/google/firebase/firestore/local/SQLiteLocalStoreTest.java

@@ -577,16 +577,18 @@ public void testDisableIndexAutoCreationWorks() {
 
   @Test
   public void testDeleteAllIndexesWorksWithIndexAutoCreation() {
-    Query query = query("coll").filter(filter("matches", "==", true));
+    Query query = query("coll").filter(filter("value", "==", "match"));
     int targetId = allocateQuery(query);
 
-    enableIndexAutoCreation();
+    setIndexAutoCreationEnabled(true);
+    setMinCollectionSizeToAutoCreateIndex(0);
+    setRelativeIndexReadCostPerDocument(2);
 
-    applyRemoteEvent(addedRemoteEvent(doc("coll/a", 10, map("matches", true)), targetId));
-    applyRemoteEvent(addedRemoteEvent(doc("coll/b", 10, map("matches", false)), targetId));
-    applyRemoteEvent(addedRemoteEvent(doc("coll/c", 10, map("matches", false)), targetId));
-    applyRemoteEvent(addedRemoteEvent(doc("coll/d", 10, map("matches", false)), targetId));
-    applyRemoteEvent(addedRemoteEvent(doc("coll/e", 10, map("matches", true)), targetId));
+    applyRemoteEvent(addedRemoteEvent(doc("coll/a", 10, map("value", "match")), targetId));
+    applyRemoteEvent(addedRemoteEvent(doc("coll/b", 10, map("value", Double.NaN)), targetId));
+    applyRemoteEvent(addedRemoteEvent(doc("coll/c", 10, map("value", null)), targetId));
+    applyRemoteEvent(addedRemoteEvent(doc("coll/d", 10, map("value", "mismatch")), targetId));
+    applyRemoteEvent(addedRemoteEvent(doc("coll/e", 10, map("value", "match")), targetId));
 
     // First time query is running without indexes.
     // Based on current heuristic, collection document counts (5) > 2 * resultSize (2).
@@ -595,7 +597,7 @@ public void testDeleteAllIndexesWorksWithIndexAutoCreation() {
     assertRemoteDocumentsRead(/* byKey= */ 0, /* byCollection= */ 2);
     assertQueryReturned("coll/a", "coll/e");
 
-    disableIndexAutoCreation();
+    setIndexAutoCreationEnabled(false);
 
     backfillIndexes();