Tests

Author: mrober

firebase-crashlytics/src/androidTest/java/com/google/firebase/crashlytics/internal/common/IdManagerTest.java

@@ -114,7 +114,7 @@ public void testInstanceIdChanges_dataCollectionEnabled() {
 
     String installId = idManager.getInstallIds().getCrashlyticsInstallId();
     assertNotNull(installId);
-    assertFalse(installId.equals(oldUuid));
+    assertThat(oldUuid).isNotEqualTo(installId);
 
     assertEquals(installId, prefs.getString(IdManager.PREFKEY_INSTALLATION_UUID, null));
     assertEquals(newFid, prefs.getString(IdManager.PREFKEY_FIREBASE_IID, null));
@@ -191,7 +191,7 @@ public void testInstanceIdRotatesWithDataCollectionFlag() {
         secondUuid,
         createIdManager(null, MOCK_ARBITER_DISABLED).getInstallIds().getCrashlyticsInstallId());
     // Check that we cached an synthetic FID
-    final SharedPreferences prefs = CommonUtils.getSharedPrefs(getContext());
+    prefs = CommonUtils.getSharedPrefs(getContext());
     String cachedFid = prefs.getString(IdManager.PREFKEY_FIREBASE_IID, null);
     assertTrue(IdManager.isSyntheticFid(cachedFid));
 
@@ -218,6 +218,12 @@ public void testIdForEntropy() {
     assertThat(idManager.getIdForEntropy()).isEqualTo(CommonUtils.sha1("Seveneves"));
   }
 
+  public void testIdForEntropy_noCache() {
+    IdManager idManager = createIdManager(null, MOCK_ARBITER_ENABLED);
+
+    assertThat(idManager.getIdForEntropy()).hasLength(32); // Length of random uuid.
+  }
+
   public void testIdForEntropy_arbiterDisabled() {
     prefs.edit().putString(IdManager.PREFKEY_INSTALLATION_UUID, "Seveneves").apply();
     IdManager idManager = createIdManager(null, MOCK_ARBITER_DISABLED);
@@ -233,9 +239,15 @@ public void testIdForEntropy_arbiterDisabled_syntheticFid() {
         .putString(IdManager.PREFKEY_INSTALLATION_UUID, "Seveneves")
         .putString(IdManager.PREFKEY_FIREBASE_IID, "SYN_") // Synthetic fid
         .apply();
-    IdManager idManager = createIdManager(null, MOCK_ARBITER_ENABLED);
+    IdManager idManager = createIdManager(null, MOCK_ARBITER_DISABLED);
 
     // Do use the cached Crashlytics id, since the cached fid is synthetic.
     assertThat(idManager.getIdForEntropy()).isEqualTo(CommonUtils.sha1("Seveneves"));
   }
+
+  public void testIdForEntropy_arbiterDisabled_noCache() {
+    IdManager idManager = createIdManager(null, MOCK_ARBITER_DISABLED);
+
+    assertThat(idManager.getIdForEntropy()).hasLength(32); // Length of random uuid.
+  }
 }