Remove publish sources (#6427)

daymxn · web-flow · commit 442bab2397cc · 2024-11-04T15:47:12.000-05:00
Per [b/377292172](https://b.corp.google.com/issues/377292172), This fixes the issue with source jars not being published. Android variants are configured at configuration time, but `withSourcesJar` is only a function. There's no way to provide a `Provider` to defer setting it. Attempting to instead call it after evaluation will result in it not actually being set. Previously, we published sources jars regardless if `publishSources` was set to false. Furthermore, no SDK actually had it set to false anyhow. So moving forward, I've just removed the setting entirely- as it wasn't really being used, it fixes our issue, and reduces maintenance costs. NO_RELEASE_CHANGE
diff --git a/appcheck/firebase-appcheck-debug-testing/firebase-appcheck-debug-testing.gradle b/appcheck/firebase-appcheck-debug-testing/firebase-appcheck-debug-testing.gradle
@@ -20,7 +20,6 @@ plugins {
 firebaseLibrary {
     libraryGroup = "appcheck"
     testLab.enabled = true
-    publishSources = true
     releaseNotes {
         name.set("{{app_check}} Debug Testing")
         versionName.set("appcheck-debug-testing")
diff --git a/appcheck/firebase-appcheck-debug/firebase-appcheck-debug.gradle b/appcheck/firebase-appcheck-debug/firebase-appcheck-debug.gradle
@@ -18,7 +18,6 @@ plugins {
 
 firebaseLibrary {
     libraryGroup = "appcheck"
-    publishSources = true
     releaseNotes {
         name.set("{{app_check}} Debug")
         versionName.set("appcheck-debug")
diff --git a/appcheck/firebase-appcheck-interop/firebase-appcheck-interop.gradle b/appcheck/firebase-appcheck-interop/firebase-appcheck-interop.gradle
@@ -17,7 +17,6 @@ plugins {
 }
 
 firebaseLibrary {
-    publishSources = true
     publishJavadoc = false
     releaseNotes { 
         enabled.set(false)
diff --git a/appcheck/firebase-appcheck-playintegrity/firebase-appcheck-playintegrity.gradle b/appcheck/firebase-appcheck-playintegrity/firebase-appcheck-playintegrity.gradle
@@ -18,7 +18,6 @@ plugins {
 
 firebaseLibrary {
     libraryGroup = "appcheck"
-    publishSources = true
     releaseNotes {
         name.set("{{app_check}} Play integrity")
         versionName.set("appcheck-playintegrity")
diff --git a/appcheck/firebase-appcheck/firebase-appcheck.gradle b/appcheck/firebase-appcheck/firebase-appcheck.gradle
@@ -19,7 +19,6 @@ plugins {
 
 firebaseLibrary {
     libraryGroup = "appcheck"
-    publishSources = true
     releaseNotes {
         name.set("{{app_check}}")
         versionName.set("appcheck")
diff --git a/appcheck/firebase-appcheck/ktx/ktx.gradle b/appcheck/firebase-appcheck/ktx/ktx.gradle
@@ -24,7 +24,6 @@ firebaseLibrary {
     releaseNotes { 
         enabled.set(false)
     }
-    publishSources = true
 }
 
 android {
diff --git a/buildSrc/src/main/java/com/google/firebase/gradle/plugins/BaseFirebaseLibraryPlugin.kt b/buildSrc/src/main/java/com/google/firebase/gradle/plugins/BaseFirebaseLibraryPlugin.kt
@@ -53,7 +53,6 @@ abstract class BaseFirebaseLibraryPlugin : Plugin<Project> {
     with(library) {
       previewMode.convention("")
       publishJavadoc.convention(true)
-      publishSources.convention(true)
       artifactId.convention(project.name)
       groupId.convention(project.provider { project.group.toString() })
       libraryGroup.convention(artifactId)
diff --git a/buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseAndroidLibraryPlugin.kt b/buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseAndroidLibraryPlugin.kt
@@ -18,7 +18,6 @@ package com.google.firebase.gradle.plugins
 
 import com.android.build.gradle.LibraryExtension
 import com.android.build.gradle.LibraryPlugin
-import com.android.build.gradle.internal.crash.afterEvaluate
 import com.google.firebase.gradle.plugins.LibraryType.ANDROID
 import com.google.firebase.gradle.plugins.ci.device.FirebaseTestServer
 import com.google.firebase.gradle.plugins.license.LicenseResolverPlugin
@@ -199,13 +198,8 @@ class FirebaseAndroidLibraryPlugin : BaseFirebaseLibraryPlugin() {
     firebaseLibrary: FirebaseLibraryExtension,
     android: LibraryExtension,
   ) {
-    android.publishing.singleVariant("release") {
-      project.afterEvaluate {
-        if (firebaseLibrary.publishSources.get()) {
-          withSourcesJar()
-        }
-      }
-    }
+    android.publishing.singleVariant("release") { withSourcesJar() }
+
     project.tasks.withType<GenerateModuleMetadata> { isEnabled = false }
 
     configurePublishing(project, firebaseLibrary)
diff --git a/buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseLibraryExtension.kt b/buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseLibraryExtension.kt
@@ -69,20 +69,6 @@ constructor(val project: Project, val type: LibraryType) {
    */
   abstract val publishJavadoc: Property<Boolean>
 
-  /**
-   * Publish source files for this library.
-   *
-   * Publishing sources alongside your standard `jar` or `aar` allows the IDE to offer better
-   * auto-complete and inline linkage.
-   *
-   * If your SDK lives in the public repo, there's no real reason for you to have this disabled.
-   *
-   * Defaults to `true`.
-   *
-   * @see [FirebaseLibraryExtension]
-   */
-  abstract val publishSources: Property<Boolean>
-
   /**
    * Indicates the library is in a preview mode (such as `alpha` or `beta`).
    *
diff --git a/contributor-docs/onboarding/new_sdk.md b/contributor-docs/onboarding/new_sdk.md
@@ -75,7 +75,6 @@ plugins {
 firebaseLibrary {
     // enable this only if you have tests in `androidTest`.
     testLab.enabled = true
-    publishSources = true
     publishJavadoc = true
 }
 
diff --git a/encoders/firebase-decoders-json/firebase-decoders-json.gradle b/encoders/firebase-decoders-json/firebase-decoders-json.gradle
@@ -17,7 +17,6 @@ plugins {
 }
 
 firebaseLibrary {
-    publishSources = true
     publishJavadoc = false
     releaseNotes { 
         enabled.set(false)
diff --git a/encoders/firebase-encoders-json/firebase-encoders-json.gradle b/encoders/firebase-encoders-json/firebase-encoders-json.gradle
@@ -18,7 +18,6 @@ plugins {
 }
 
 firebaseLibrary {
-    publishSources = true
     publishJavadoc = false
     releaseNotes { 
         enabled.set(false)
diff --git a/encoders/firebase-encoders-proto/firebase-encoders-proto.gradle b/encoders/firebase-encoders-proto/firebase-encoders-proto.gradle
@@ -18,7 +18,6 @@ plugins {
 }
 
 firebaseLibrary {
-    publishSources = true
     publishJavadoc = false
     releaseNotes { 
         enabled.set(false)
diff --git a/encoders/firebase-encoders-reflective/firebase-encoders-reflective.gradle b/encoders/firebase-encoders-reflective/firebase-encoders-reflective.gradle
@@ -17,7 +17,6 @@ plugins {
 }
 
 firebaseLibrary {
-    publishSources = true
     publishJavadoc = false
     releaseNotes { 
         enabled.set(false)
diff --git a/encoders/firebase-encoders/firebase-encoders.gradle b/encoders/firebase-encoders/firebase-encoders.gradle
@@ -17,7 +17,6 @@ plugins {
 }
 
 firebaseLibrary {
-    publishSources = true
     publishJavadoc = false
     releaseNotes { 
         enabled.set(false)
diff --git a/firebase-abt/firebase-abt.gradle b/firebase-abt/firebase-abt.gradle
@@ -18,7 +18,6 @@ plugins {
 
 firebaseLibrary {
     testLab.enabled = false
-    publishSources = true
     publishJavadoc = false
     releaseNotes {
         name.set("{{ab_testing}}")
diff --git a/firebase-annotations/firebase-annotations.gradle.kts b/firebase-annotations/firebase-annotations.gradle.kts
@@ -15,7 +15,6 @@
 plugins { id("firebase-java-library") }
 
 firebaseLibrary {
-  publishSources = true
   publishJavadoc = false
   releaseNotes { enabled.set(false) }
 }
diff --git a/firebase-appdistribution-api/ktx/ktx.gradle b/firebase-appdistribution-api/ktx/ktx.gradle
@@ -24,7 +24,6 @@ firebaseLibrary {
     releaseNotes { 
         enabled.set(false)
     }
-    publishSources = true
     previewMode = "beta"
 }
 
diff --git a/firebase-common/firebase-common.gradle.kts b/firebase-common/firebase-common.gradle.kts
@@ -20,7 +20,6 @@ plugins {
 firebaseLibrary {
   libraryGroup = "common"
   testLab.enabled = true
-  publishSources = true
   releaseNotes { enabled = false }
 }
 
diff --git a/firebase-components/firebase-components.gradle.kts b/firebase-components/firebase-components.gradle.kts
@@ -15,7 +15,6 @@
 plugins { id("firebase-library") }
 
 firebaseLibrary {
-  publishSources = true
   publishJavadoc = false
   releaseNotes { enabled.set(false) }
 }
diff --git a/firebase-components/firebase-dynamic-module-support/firebase-dynamic-module-support.gradle.kts b/firebase-components/firebase-dynamic-module-support/firebase-dynamic-module-support.gradle.kts
@@ -18,7 +18,6 @@ group = "com.google.firebase"
 
 firebaseLibrary {
   testLab.enabled = false
-  publishSources = true
   publishJavadoc = false
   releaseNotes {
     name.set("Dynamic feature modules support")
diff --git a/firebase-config-interop/firebase-config-interop.gradle.kts b/firebase-config-interop/firebase-config-interop.gradle.kts
@@ -17,7 +17,6 @@
 plugins { id("firebase-library") }
 
 firebaseLibrary {
-  publishSources = true
   publishJavadoc = false
   releaseNotes { enabled.set(false) }
 }
diff --git a/firebase-config/firebase-config.gradle.kts b/firebase-config/firebase-config.gradle.kts
@@ -22,7 +22,6 @@ plugins {
 firebaseLibrary {
   libraryGroup = "config"
   testLab.enabled = true
-  publishSources = true
   releaseNotes {
     name.set("{{remote_config}}")
     versionName.set("remote-config")
diff --git a/firebase-config/ktx/ktx.gradle b/firebase-config/ktx/ktx.gradle
@@ -23,7 +23,6 @@ firebaseLibrary {
     releaseNotes { 
         enabled.set(false)
     }
-    publishSources = true
 }
 
 android {
diff --git a/firebase-crashlytics/ktx/ktx.gradle b/firebase-crashlytics/ktx/ktx.gradle
@@ -24,7 +24,6 @@ firebaseLibrary {
   releaseNotes { 
     enabled.set(false)
 }
-  publishSources = true
 }
 
 android {
diff --git a/firebase-database-collection/firebase-database-collection.gradle.kts b/firebase-database-collection/firebase-database-collection.gradle.kts
@@ -15,7 +15,6 @@
 plugins { id("firebase-library") }
 
 firebaseLibrary {
-  publishSources = true
   publishJavadoc = false
   releaseNotes { enabled.set(false) }
 }
diff --git a/firebase-database/firebase-database.gradle.kts b/firebase-database/firebase-database.gradle.kts
@@ -21,7 +21,6 @@ plugins {
 firebaseLibrary {
   libraryGroup = "database"
   testLab.enabled = true
-  publishSources = true
   releaseNotes {
     name.set("{{database}}")
     versionName.set("realtime-database")
diff --git a/firebase-database/ktx/ktx.gradle.kts b/firebase-database/ktx/ktx.gradle.kts
@@ -24,7 +24,6 @@ firebaseLibrary {
   libraryGroup = "database"
   publishJavadoc = false
   releaseNotes { enabled.set(false) }
-  publishSources = true
 }
 
 android {
diff --git a/firebase-dataconnect/firebase-dataconnect.gradle.kts b/firebase-dataconnect/firebase-dataconnect.gradle.kts
@@ -27,7 +27,6 @@ plugins {
 firebaseLibrary {
   libraryGroup = "dataconnect"
   testLab.enabled = false
-  publishSources = true
   publishJavadoc = false
   previewMode = "beta"
   releaseNotes {
diff --git a/firebase-datatransport/firebase-datatransport.gradle b/firebase-datatransport/firebase-datatransport.gradle
@@ -21,7 +21,6 @@ firebaseLibrary {
     releaseNotes { 
         enabled.set(false)
     }
-    publishSources = true
 }
 
 android {
diff --git a/firebase-dynamic-links/firebase-dynamic-links.gradle b/firebase-dynamic-links/firebase-dynamic-links.gradle
@@ -20,7 +20,6 @@ plugins {
 firebaseLibrary {
     libraryGroup = "dynamic-links"
     testLab.enabled = false
-    publishSources = true
     releaseNotes {
         name.set("{{ddls}}")
         versionName.set("dynamic-links")
diff --git a/firebase-dynamic-links/ktx/ktx.gradle b/firebase-dynamic-links/ktx/ktx.gradle
@@ -23,7 +23,6 @@ firebaseLibrary {
     releaseNotes { 
         enabled.set(false)
     }
-    publishSources = true
 }
 
 android {
diff --git a/firebase-firestore/firebase-firestore.gradle b/firebase-firestore/firebase-firestore.gradle
@@ -21,7 +21,6 @@ plugins {
 
 firebaseLibrary {
     libraryGroup = "firestore"
-    publishSources = true
     testLab {
         enabled = true
         timeout = '45m'
diff --git a/firebase-firestore/ktx/ktx.gradle b/firebase-firestore/ktx/ktx.gradle
@@ -21,7 +21,6 @@ group = "com.google.firebase"
 
 firebaseLibrary {
     libraryGroup = "firestore"
-    publishSources = true
     publishJavadoc = false
     releaseNotes { 
         enabled.set(false)
diff --git a/firebase-functions/firebase-functions.gradle.kts b/firebase-functions/firebase-functions.gradle.kts
@@ -25,7 +25,6 @@ plugins {
 firebaseLibrary {
   libraryGroup = "functions"
   testLab.enabled = true
-  publishSources = true
   releaseNotes {
     name.set("{{functions_client}}")
     versionName.set("functions-client")
diff --git a/firebase-functions/ktx/ktx.gradle.kts b/firebase-functions/ktx/ktx.gradle.kts
@@ -21,7 +21,6 @@ firebaseLibrary {
   libraryGroup = "functions"
   publishJavadoc = false
   releaseNotes { enabled.set(false) }
-  publishSources = true
   testLab.enabled = true
 }
 
diff --git a/firebase-inappmessaging-display/ktx/ktx.gradle b/firebase-inappmessaging-display/ktx/ktx.gradle
@@ -23,7 +23,6 @@ firebaseLibrary {
     releaseNotes { 
         enabled.set(false)
     }
-    publishSources = true
 }
 
 android {
diff --git a/firebase-inappmessaging/ktx/ktx.gradle b/firebase-inappmessaging/ktx/ktx.gradle
@@ -23,7 +23,6 @@ firebaseLibrary {
     releaseNotes { 
         enabled.set(false)
     }
-    publishSources = true
 }
 
 android {
diff --git a/firebase-installations/ktx/ktx.gradle b/firebase-installations/ktx/ktx.gradle
@@ -23,7 +23,6 @@ firebaseLibrary {
     releaseNotes { 
         enabled.set(false)
     }
-    publishSources = true
 }
 
 android {
diff --git a/firebase-messaging/ktx/ktx.gradle b/firebase-messaging/ktx/ktx.gradle
@@ -23,7 +23,6 @@ firebaseLibrary {
     releaseNotes { 
         enabled.set(false)
     }
-    publishSources = true
 }
 
 android {
diff --git a/firebase-ml-modeldownloader/ktx/ktx.gradle b/firebase-ml-modeldownloader/ktx/ktx.gradle
@@ -23,7 +23,6 @@ firebaseLibrary {
     releaseNotes { 
         enabled.set(false)
     }
-    publishSources = true
     testLab.enabled = false
 }
 
diff --git a/firebase-perf/ktx/ktx.gradle b/firebase-perf/ktx/ktx.gradle
@@ -23,7 +23,6 @@ firebaseLibrary {
     releaseNotes { 
         enabled.set(false)
     }
-    publishSources = true
 }
 
 android {
diff --git a/firebase-sessions/firebase-sessions.gradle.kts b/firebase-sessions/firebase-sessions.gradle.kts
@@ -26,7 +26,6 @@ firebaseLibrary {
   libraryGroup = "crashlytics"
 
   testLab.enabled = true
-  publishSources = true
   publishJavadoc = false
   releaseNotes { enabled.set(false) }
 }
diff --git a/firebase-storage/firebase-storage.gradle b/firebase-storage/firebase-storage.gradle
@@ -23,7 +23,6 @@ firebaseLibrary {
     libraryGroup = "storage"
     testLab.enabled = true
     publishJavadoc = true
-    publishSources = true
     releaseNotes {
         name.set("{{firebase_storage_full}}")
         versionName.set("storage")
diff --git a/firebase-storage/ktx/ktx.gradle b/firebase-storage/ktx/ktx.gradle
@@ -25,7 +25,6 @@ firebaseLibrary {
     releaseNotes { 
         enabled.set(false)
     }
-    publishSources = true
 }
 
 android {
diff --git a/firebase-vertexai/firebase-vertexai.gradle.kts b/firebase-vertexai/firebase-vertexai.gradle.kts
@@ -26,7 +26,6 @@ plugins {
 
 firebaseLibrary {
   testLab.enabled = false
-  publishSources = true
   publishJavadoc = true
   releaseNotes {
     name.set("{{firebase_vertexai}}")

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@ plugins {`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`firebaseLibrary {`
`20`		`- publishSources = true`
`21`	`20`	`publishJavadoc = false`
`22`	`21`	`releaseNotes {`
`23`	`22`	`enabled.set(false)`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@ firebaseLibrary {`
`24`	`24`	`releaseNotes {`
`25`	`25`	`enabled.set(false)`
`26`	`26`	`}`
`27`		`- publishSources = true`
`28`	`27`	`}`
`29`	`28`
`30`	`29`	`android {`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@ plugins {`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`firebaseLibrary {`
`21`		`- publishSources = true`
`22`	`21`	`publishJavadoc = false`
`23`	`22`	`releaseNotes {`
`24`	`23`	`enabled.set(false)`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@`
`15`	`15`	`plugins { id("firebase-java-library") }`
`16`	`16`
`17`	`17`	`firebaseLibrary {`
`18`		`- publishSources = true`
`19`	`18`	`publishJavadoc = false`
`20`	`19`	`releaseNotes { enabled.set(false) }`
`21`	`20`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@ plugins {`
`20`	`20`	`firebaseLibrary {`
`21`	`21`	`libraryGroup = "common"`
`22`	`22`	`testLab.enabled = true`
`23`		`- publishSources = true`
`24`	`23`	`releaseNotes { enabled = false }`
`25`	`24`	`}`
`26`	`25`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@`
`17`	`17`	`plugins { id("firebase-library") }`
`18`	`18`
`19`	`19`	`firebaseLibrary {`
`20`		`- publishSources = true`
`21`	`20`	`publishJavadoc = false`
`22`	`21`	`releaseNotes { enabled.set(false) }`
`23`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@ firebaseLibrary {`
`23`	`23`	`releaseNotes {`
`24`	`24`	`enabled.set(false)`
`25`	`25`	`}`
`26`		`- publishSources = true`
`27`	`26`	`}`
`28`	`27`
`29`	`28`	`android {`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,6 @@ firebaseLibrary {`
`21`	`21`	`releaseNotes {`
`22`	`22`	`enabled.set(false)`
`23`	`23`	`}`
`24`		`- publishSources = true`
`25`	`24`	`}`
`26`	`25`
`27`	`26`	`android {`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,6 @@ firebaseLibrary {`
`26`	`26`	`libraryGroup = "crashlytics"`
`27`	`27`
`28`	`28`	`testLab.enabled = true`
`29`		`- publishSources = true`
`30`	`29`	`publishJavadoc = false`
`31`	`30`	`releaseNotes { enabled.set(false) }`
`32`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@ firebaseLibrary {`
`25`	`25`	`releaseNotes {`
`26`	`26`	`enabled.set(false)`
`27`	`27`	`}`
`28`		`- publishSources = true`
`29`	`28`	`}`
`30`	`29`
`31`	`30`	`android {`