Skip to content

Commit 42308d8

Browse files
authored
Create a separate package for Application Handlers (#2527)
1 parent cdc3aff commit 42308d8

File tree

20 files changed

+76
-35
lines changed

20 files changed

+76
-35
lines changed

firebase-perf/ktx/src/test/kotlin/com/google/firebase/perf/ktx/PerformanceTests.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import com.google.firebase.ktx.app
2222
import com.google.firebase.ktx.initialize
2323
import com.google.firebase.perf.FirebasePerformance
2424
import com.google.firebase.perf.FirebasePerformance.HttpMethod
25-
import com.google.firebase.perf.internal.AppStateMonitor
25+
import com.google.firebase.perf.application.AppStateMonitor
2626
import com.google.firebase.perf.metrics.HttpMetric
2727
import com.google.firebase.perf.metrics.Trace
2828
import com.google.firebase.perf.metrics.getTraceCounter

firebase-perf/src/main/java/com/google/firebase/perf/internal/AppStateMonitor.java renamed to firebase-perf/src/main/java/com/google/firebase/perf/application/AppStateMonitor.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
// Copyright 2020 Google LLC
1+
// Copyright 2021 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
5-
//
65
// You may obtain a copy of the License at
6+
//
77
// http://www.apache.org/licenses/LICENSE-2.0
88
//
99
// Unless required by applicable law or agreed to in writing, software
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.internal;
15+
package com.google.firebase.perf.application;
1616

1717
import android.app.Activity;
1818
import android.app.Application;
@@ -25,6 +25,7 @@
2525
import androidx.core.app.FrameMetricsAggregator;
2626
import com.google.android.gms.common.util.VisibleForTesting;
2727
import com.google.firebase.perf.config.ConfigResolver;
28+
import com.google.firebase.perf.internal.SessionManager;
2829
import com.google.firebase.perf.logging.AndroidLogger;
2930
import com.google.firebase.perf.metrics.Trace;
3031
import com.google.firebase.perf.transport.TransportManager;
@@ -468,7 +469,7 @@ Timer getResumeTime() {
468469
}
469470

470471
@VisibleForTesting
471-
void setIsColdStart(boolean isColdStart) {
472+
public void setIsColdStart(boolean isColdStart) {
472473
mIsColdStart = isColdStart;
473474
}
474475
}

firebase-perf/src/main/java/com/google/firebase/perf/internal/AppStateUpdateHandler.java renamed to firebase-perf/src/main/java/com/google/firebase/perf/application/AppStateUpdateHandler.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
// Copyright 2020 Google LLC
1+
// Copyright 2021 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
5-
//
65
// You may obtain a copy of the License at
6+
//
77
// http://www.apache.org/licenses/LICENSE-2.0
88
//
99
// Unless required by applicable law or agreed to in writing, software
@@ -12,10 +12,10 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.internal;
15+
package com.google.firebase.perf.application;
1616

1717
import androidx.annotation.NonNull;
18-
import com.google.firebase.perf.internal.AppStateMonitor.AppStateCallback;
18+
import com.google.firebase.perf.application.AppStateMonitor.AppStateCallback;
1919
import com.google.firebase.perf.v1.ApplicationProcessState;
2020
import java.lang.ref.WeakReference;
2121

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
// Copyright 2021 Google LLC
2+
//
3+
// Licensed under the Apache License, Version 2.0 (the "License");
4+
// you may not use this file except in compliance with the License.
5+
// You may obtain a copy of the License at
6+
//
7+
// http://www.apache.org/licenses/LICENSE-2.0
8+
//
9+
// Unless required by applicable law or agreed to in writing, software
10+
// distributed under the License is distributed on an "AS IS" BASIS,
11+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
// See the License for the specific language governing permissions and
13+
// limitations under the License.
14+
15+
/** @hide */
16+
/** @hide */
17+
package com.google.firebase.perf.application;

firebase-perf/src/main/java/com/google/firebase/perf/internal/SessionManager.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
import android.annotation.SuppressLint;
1818
import androidx.annotation.Keep;
1919
import com.google.android.gms.common.util.VisibleForTesting;
20+
import com.google.firebase.perf.application.AppStateMonitor;
21+
import com.google.firebase.perf.application.AppStateUpdateHandler;
2022
import com.google.firebase.perf.v1.ApplicationProcessState;
2123
import com.google.firebase.perf.v1.GaugeMetadata;
2224
import com.google.firebase.perf.v1.GaugeMetric;

firebase-perf/src/main/java/com/google/firebase/perf/metrics/NetworkRequestMetricBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818

1919
import androidx.annotation.Nullable;
2020
import androidx.annotation.VisibleForTesting;
21-
import com.google.firebase.perf.internal.AppStateMonitor;
22-
import com.google.firebase.perf.internal.AppStateUpdateHandler;
21+
import com.google.firebase.perf.application.AppStateMonitor;
22+
import com.google.firebase.perf.application.AppStateUpdateHandler;
2323
import com.google.firebase.perf.internal.GaugeManager;
2424
import com.google.firebase.perf.internal.PerfSession;
2525
import com.google.firebase.perf.internal.SessionAwareObject;

firebase-perf/src/main/java/com/google/firebase/perf/metrics/Trace.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
import androidx.annotation.Nullable;
2222
import com.google.android.gms.common.util.VisibleForTesting;
2323
import com.google.firebase.perf.FirebasePerformanceAttributable;
24+
import com.google.firebase.perf.application.AppStateMonitor;
25+
import com.google.firebase.perf.application.AppStateUpdateHandler;
2426
import com.google.firebase.perf.config.ConfigResolver;
25-
import com.google.firebase.perf.internal.AppStateMonitor;
26-
import com.google.firebase.perf.internal.AppStateUpdateHandler;
2727
import com.google.firebase.perf.internal.GaugeManager;
2828
import com.google.firebase.perf.internal.PerfSession;
2929
import com.google.firebase.perf.internal.SessionAwareObject;

firebase-perf/src/main/java/com/google/firebase/perf/internal/ResourceType.java renamed to firebase-perf/src/main/java/com/google/firebase/perf/metrics/resource/ResourceType.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
// Copyright 2020 Google LLC
1+
// Copyright 2021 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
5-
//
65
// You may obtain a copy of the License at
6+
//
77
// http://www.apache.org/licenses/LICENSE-2.0
88
//
99
// Unless required by applicable law or agreed to in writing, software
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.internal;
15+
package com.google.firebase.perf.metrics.resource;
1616

1717
import androidx.annotation.StringDef;
1818
import java.lang.annotation.Retention;
@@ -21,6 +21,7 @@
2121
/** Annotates various resource types in Firebase Performance. */
2222
@StringDef({ResourceType.TRACE, ResourceType.NETWORK})
2323
@Retention(RetentionPolicy.RUNTIME)
24+
/** @hide */
2425
public @interface ResourceType {
2526
String TRACE = "Trace";
2627
String NETWORK = "Network";
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
// Copyright 2021 Google LLC
2+
//
3+
// Licensed under the Apache License, Version 2.0 (the "License");
4+
// you may not use this file except in compliance with the License.
5+
// You may obtain a copy of the License at
6+
//
7+
// http://www.apache.org/licenses/LICENSE-2.0
8+
//
9+
// Unless required by applicable law or agreed to in writing, software
10+
// distributed under the License is distributed on an "AS IS" BASIS,
11+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
// See the License for the specific language governing permissions and
13+
// limitations under the License.
14+
15+
/** @hide */
16+
/** @hide */
17+
package com.google.firebase.perf.metrics.resource;
18+

firebase-perf/src/main/java/com/google/firebase/perf/provider/FirebasePerfProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828
import androidx.annotation.Nullable;
2929
import com.google.android.gms.common.internal.Preconditions;
3030
import com.google.android.gms.common.util.VisibleForTesting;
31+
import com.google.firebase.perf.application.AppStateMonitor;
3132
import com.google.firebase.perf.config.ConfigResolver;
32-
import com.google.firebase.perf.internal.AppStateMonitor;
3333
import com.google.firebase.perf.internal.SessionManager;
3434
import com.google.firebase.perf.metrics.AppStartTrace;
3535
import com.google.firebase.perf.util.Clock;

firebase-perf/src/main/java/com/google/firebase/perf/transport/RateLimiter.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,15 @@
1414

1515
package com.google.firebase.perf.transport;
1616

17-
import static com.google.firebase.perf.internal.ResourceType.NETWORK;
18-
import static com.google.firebase.perf.internal.ResourceType.TRACE;
17+
import static com.google.firebase.perf.metrics.resource.ResourceType.NETWORK;
18+
import static com.google.firebase.perf.metrics.resource.ResourceType.TRACE;
1919

2020
import android.content.Context;
2121
import androidx.annotation.NonNull;
2222
import com.google.android.gms.common.util.VisibleForTesting;
2323
import com.google.firebase.perf.config.ConfigResolver;
24-
import com.google.firebase.perf.internal.ResourceType;
2524
import com.google.firebase.perf.logging.AndroidLogger;
25+
import com.google.firebase.perf.metrics.resource.ResourceType;
2626
import com.google.firebase.perf.util.Clock;
2727
import com.google.firebase.perf.util.Constants;
2828
import com.google.firebase.perf.util.Timer;

firebase-perf/src/main/java/com/google/firebase/perf/transport/TransportManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@
3131
import com.google.firebase.installations.FirebaseInstallationsApi;
3232
import com.google.firebase.perf.BuildConfig;
3333
import com.google.firebase.perf.FirebasePerformance;
34+
import com.google.firebase.perf.application.AppStateMonitor;
35+
import com.google.firebase.perf.application.AppStateMonitor.AppStateCallback;
3436
import com.google.firebase.perf.config.ConfigResolver;
35-
import com.google.firebase.perf.internal.AppStateMonitor;
36-
import com.google.firebase.perf.internal.AppStateMonitor.AppStateCallback;
3737
import com.google.firebase.perf.internal.SessionManager;
3838
import com.google.firebase.perf.logging.AndroidLogger;
3939
import com.google.firebase.perf.metrics.validator.PerfMetricValidator;

firebase-perf/src/test/java/com/google/firebase/perf/internal/AppStateMonitorTest.java renamed to firebase-perf/src/test/java/com/google/firebase/perf/application/AppStateMonitorTest.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
// Copyright 2020 Google LLC
1+
// Copyright 2021 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
5-
//
65
// You may obtain a copy of the License at
6+
//
77
// http://www.apache.org/licenses/LICENSE-2.0
88
//
99
// Unless required by applicable law or agreed to in writing, software
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.internal;
15+
package com.google.firebase.perf.application;
1616

1717
import static com.google.common.truth.Truth.assertThat;
1818
import static com.google.firebase.perf.v1.ApplicationProcessState.FOREGROUND_BACKGROUND;
@@ -35,6 +35,7 @@
3535
import com.google.firebase.perf.FirebasePerformanceTestBase;
3636
import com.google.firebase.perf.config.ConfigResolver;
3737
import com.google.firebase.perf.config.DeviceCacheManager;
38+
import com.google.firebase.perf.internal.GaugeManager;
3839
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
3940
import com.google.firebase.perf.metrics.Trace;
4041
import com.google.firebase.perf.transport.TransportManager;
@@ -60,7 +61,7 @@
6061
import org.robolectric.RobolectricTestRunner;
6162
import org.robolectric.android.controller.ActivityController;
6263

63-
/** Unit tests for {@link AppStateMonitor}. */
64+
/** Unit tests for {@link com.google.firebase.perf.application.AppStateMonitor}. */
6465
@RunWith(RobolectricTestRunner.class)
6566
public class AppStateMonitorTest extends FirebasePerformanceTestBase {
6667

firebase-perf/src/test/java/com/google/firebase/perf/internal/SessionManagerTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
// Copyright 2020 Google LLC
1+
// Copyright 2021 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
5-
//
65
// You may obtain a copy of the License at
6+
//
77
// http://www.apache.org/licenses/LICENSE-2.0
88
//
99
// Unless required by applicable law or agreed to in writing, software
@@ -26,6 +26,7 @@
2626
import static org.mockito.MockitoAnnotations.initMocks;
2727

2828
import com.google.firebase.perf.FirebasePerformanceTestBase;
29+
import com.google.firebase.perf.application.AppStateMonitor;
2930
import com.google.firebase.perf.v1.ApplicationProcessState;
3031
import java.lang.ref.WeakReference;
3132
import org.junit.Before;

firebase-perf/src/test/java/com/google/firebase/perf/metrics/NetworkRequestMetricBuilderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import static org.mockito.MockitoAnnotations.initMocks;
2222

2323
import com.google.firebase.perf.FirebasePerformanceTestBase;
24-
import com.google.firebase.perf.internal.AppStateMonitor;
24+
import com.google.firebase.perf.application.AppStateMonitor;
2525
import com.google.firebase.perf.internal.GaugeManager;
2626
import com.google.firebase.perf.internal.PerfSession;
2727
import com.google.firebase.perf.internal.SessionManager;

firebase-perf/src/test/java/com/google/firebase/perf/metrics/TraceMetricBuilderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import static org.mockito.MockitoAnnotations.initMocks;
1919

2020
import com.google.firebase.perf.FirebasePerformanceTestBase;
21-
import com.google.firebase.perf.internal.AppStateMonitor;
21+
import com.google.firebase.perf.application.AppStateMonitor;
2222
import com.google.firebase.perf.transport.TransportManager;
2323
import com.google.firebase.perf.util.Clock;
2424
import com.google.firebase.perf.util.Constants;

firebase-perf/src/test/java/com/google/firebase/perf/metrics/TraceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@
2929
import android.content.Context;
3030
import android.os.Parcel;
3131
import com.google.firebase.perf.FirebasePerformanceTestBase;
32+
import com.google.firebase.perf.application.AppStateMonitor;
3233
import com.google.firebase.perf.config.ConfigResolver;
3334
import com.google.firebase.perf.config.DeviceCacheManager;
34-
import com.google.firebase.perf.internal.AppStateMonitor;
3535
import com.google.firebase.perf.internal.GaugeManager;
3636
import com.google.firebase.perf.internal.PerfSession;
3737
import com.google.firebase.perf.internal.SessionManager;

firebase-perf/src/test/java/com/google/firebase/perf/metrics/validator/FirebasePerfTraceValidatorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import static org.mockito.MockitoAnnotations.initMocks;
2222

2323
import com.google.firebase.perf.FirebasePerformanceTestBase;
24-
import com.google.firebase.perf.internal.AppStateMonitor;
24+
import com.google.firebase.perf.application.AppStateMonitor;
2525
import com.google.firebase.perf.metrics.Trace;
2626
import com.google.firebase.perf.transport.TransportManager;
2727
import com.google.firebase.perf.util.Clock;

firebase-perf/src/test/java/com/google/firebase/perf/transport/RateLimiterTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
package com.google.firebase.perf.transport;
1616

1717
import static com.google.common.truth.Truth.assertThat;
18-
import static com.google.firebase.perf.internal.ResourceType.NETWORK;
19-
import static com.google.firebase.perf.internal.ResourceType.TRACE;
18+
import static com.google.firebase.perf.metrics.resource.ResourceType.NETWORK;
19+
import static com.google.firebase.perf.metrics.resource.ResourceType.TRACE;
2020
import static org.mockito.Mockito.doAnswer;
2121
import static org.mockito.Mockito.when;
2222
import static org.mockito.MockitoAnnotations.initMocks;

firebase-perf/src/test/java/com/google/firebase/perf/transport/TransportManagerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232
import com.google.firebase.installations.FirebaseInstallationsApi;
3333
import com.google.firebase.perf.FirebasePerformance;
3434
import com.google.firebase.perf.FirebasePerformanceTestBase;
35+
import com.google.firebase.perf.application.AppStateMonitor;
3536
import com.google.firebase.perf.config.ConfigResolver;
36-
import com.google.firebase.perf.internal.AppStateMonitor;
3737
import com.google.firebase.perf.internal.SessionManager;
3838
import com.google.firebase.perf.shadows.ShadowPreconditions;
3939
import com.google.firebase.perf.util.Clock;

0 commit comments

Comments
 (0)