Remove pom deps after iteration. (#1563)

Removing them during iteration mutates the node list making us skip the
dep immediately following the removed dep.

Author: vkryachko

buildSrc/src/main/java/com/google/firebase/gradle/plugins/publish/Publisher.java

@@ -93,15 +93,17 @@ private static void processDependencies(FirebaseLibraryExtension library, Elemen
     Map<String, String> deps = getDependencyTypes(library.project);
 
     NodeList dependencies = rootElement.getElementsByTagName("dependency");
+    List<Element> depsToRemove = new ArrayList<>();
     for (int i = 0; i < dependencies.getLength(); i++) {
       Element dep = (Element) dependencies.item(i);
       String groupId = dep.getElementsByTagName("groupId").item(0).getTextContent();
       String artifactId = dep.getElementsByTagName("artifactId").item(0).getTextContent();
 
       if (SUPPORT_GROUP_IDS.contains(groupId) && "multidex".equals(artifactId)) {
-        dep.getParentNode().removeChild(dep);
+        depsToRemove.add(dep);
         continue;
       }
+
       Element type = dep.getOwnerDocument().createElement("type");
       type.setTextContent(deps.get(groupId + ":" + artifactId));
       dep.appendChild(type);
@@ -114,6 +116,9 @@ private static void processDependencies(FirebaseLibraryExtension library, Elemen
       scope.setTextContent("compile");
       dep.appendChild(scope);
     }
+    for (Element dep : depsToRemove) {
+      dep.getParentNode().removeChild(dep);
+    }
   }
 
   private static String renderVersion(String baseVersion, Mode mode) {