Skip to content

Commit 3d5b112

Browse files
committed
Minor fix
1 parent 16cc4d1 commit 3d5b112

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

firebase-installations/src/main/java/com/google/firebase/installations/FirebaseInstallations.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public class FirebaseInstallations implements FirebaseInstallationsApi {
7676
@GuardedBy("this")
7777
private String cachedFid;
7878

79-
@GuardedBy("this")
79+
@GuardedBy("FirebaseInstallations.this")
8080
private Set<FidListener> fidListeners = new HashSet<>();
8181

8282
@GuardedBy("lock")
@@ -286,12 +286,14 @@ public Task<Void> delete() {
286286
@NonNull
287287
@Override
288288
public synchronized FidListenerHandle registerFidListener(@NonNull FidListener listener) {
289-
this.fidListeners.add(listener);
289+
fidListeners.add(listener);
290290
return new FidListenerHandle() {
291291
@Override
292-
public synchronized void unregister() {
293-
if (FirebaseInstallations.this.fidListeners.contains(listener)) {
294-
FirebaseInstallations.this.fidListeners.remove(listener);
292+
public void unregister() {
293+
synchronized (FirebaseInstallations.this) {
294+
if (fidListeners.contains(listener)) {
295+
fidListeners.remove(listener);
296+
}
295297
}
296298
}
297299
};

0 commit comments

Comments
 (0)