unit test for RCc cache saving

Author: leotianlizhan

firebase-perf/src/test/java/com/google/firebase/perf/config/RemoteConfigManagerTest.java

@@ -25,6 +25,7 @@
 import androidx.annotation.NonNull;
 import com.google.android.gms.tasks.Task;
 import com.google.android.gms.tasks.TaskCompletionSource;
+import com.google.common.util.concurrent.MoreExecutors;
 import com.google.firebase.inject.Provider;
 import com.google.firebase.perf.FirebasePerformanceTestBase;
 import com.google.firebase.perf.provider.FirebasePerfProvider;
@@ -36,6 +37,7 @@
 import com.google.testing.timing.FakeScheduledExecutorService;
 import java.util.HashMap;
 import java.util.Map;
+import java.util.concurrent.ExecutorService;
 import java.util.concurrent.TimeUnit;
 import org.junit.Before;
 import org.junit.Test;
@@ -48,19 +50,26 @@
 public final class RemoteConfigManagerTest extends FirebasePerformanceTestBase {
 
   private static final String FIREPERF_FRC_NAMESPACE_NAME = "fireperf";
+  private static final FirebaseRemoteConfigValue TRUE_VALUE =
+      new RemoteConfigValueImplForTest("true");
+  private static final FirebaseRemoteConfigValue FALSE_VALUE =
+      new RemoteConfigValueImplForTest("false");
 
   @Mock private FirebaseRemoteConfig mockFirebaseRemoteConfig;
   @Mock private RemoteConfigComponent mockFirebaseRemoteConfigComponent;
   @Mock private Provider<RemoteConfigComponent> mockFirebaseRemoteConfigProvider;
-  @Mock private DeviceCacheManager mockCacheManager;
 
+  private DeviceCacheManager cacheManager;
+  private ExecutorService directExecutor;
   private FakeScheduledExecutorService fakeExecutor;
 
   @Before
   public void setUp() {
     initMocks(this);
 
     fakeExecutor = new FakeScheduledExecutorService();
+    directExecutor = MoreExecutors.newDirectExecutorService();
+    cacheManager = new DeviceCacheManager(directExecutor);
 
     when(mockFirebaseRemoteConfigProvider.get()).thenReturn(mockFirebaseRemoteConfigComponent);
     when(mockFirebaseRemoteConfigComponent.get(FIREPERF_FRC_NAMESPACE_NAME))
@@ -231,6 +240,29 @@ public void getString_validFrcValue_updatesWithNewValue() {
     assertThat(testRemoteConfigManager.getString("some_key3").isAvailable()).isFalse();
   }
 
+  @Test
+  public void syncConfigValues_savesNewlyFetchedValueToDeviceCache() {
+    Map<String, FirebaseRemoteConfigValue> configs = new HashMap<>();
+    ConfigurationConstants.ExperimentTTID flag =
+        ConfigurationConstants.ExperimentTTID.getInstance();
+    configs.put(flag.getRemoteConfigFlag(), TRUE_VALUE);
+    RemoteConfigManager testRemoteConfigManager = setupTestRemoteConfigManager(configs);
+
+    assertThat(cacheManager.getBoolean(flag.getDeviceCacheFlag()).isAvailable()).isFalse();
+
+    configs.put(flag.getRemoteConfigFlag(), FALSE_VALUE);
+    testRemoteConfigManager.syncConfigValues(configs);
+
+    assertThat(cacheManager.getBoolean(flag.getDeviceCacheFlag()).isAvailable()).isTrue();
+    assertThat(cacheManager.getBoolean(flag.getDeviceCacheFlag()).get()).isFalse();
+
+    configs.put(flag.getRemoteConfigFlag(), TRUE_VALUE);
+    testRemoteConfigManager.syncConfigValues(configs);
+
+    assertThat(cacheManager.getBoolean(flag.getDeviceCacheFlag()).isAvailable()).isTrue();
+    assertThat(cacheManager.getBoolean(flag.getDeviceCacheFlag()).get()).isTrue();
+  }
+
   @Test
   public void getRemoteConfigValueOrDefaultLong_invalidFrcValue_returnsDefaultValue() {
     Map<String, FirebaseRemoteConfigValue> configs = createDefaultRcConfigMap();
@@ -890,10 +922,10 @@ private RemoteConfigManager setupTestRemoteConfigManager(
     when(mockFirebaseRemoteConfig.getAll()).thenReturn(configs);
     if (initializeFrc) {
       return new RemoteConfigManager(
-          mockCacheManager, fakeExecutor, mockFirebaseRemoteConfig, appStartConfigFetchDelayInMs);
+          cacheManager, fakeExecutor, mockFirebaseRemoteConfig, appStartConfigFetchDelayInMs);
     } else {
       return new RemoteConfigManager(
-          mockCacheManager,
+          cacheManager,
           fakeExecutor,
           /* firebaseRemoteConfig= */ null,
           appStartConfigFetchDelayInMs);