Remove some TODOs (#3280)

lfkellogg · web-flow · commit 34778486a15e · 2021-12-29T18:40:27.000-05:00
diff --git a/firebase-app-distribution/src/main/java/com/google/firebase/app/distribution/ApkUpdater.java b/firebase-app-distribution/src/main/java/com/google/firebase/app/distribution/ApkUpdater.java
@@ -152,7 +152,6 @@ Task<File> downloadApk(
     return downloadTaskCompletionSource.getTask();
   }
 
-  // TODO(lkellogg): The happy path in this method is not exercised by any tests right now
   private void makeApkDownloadRequest(
       @NonNull AppDistributionReleaseInternal newRelease, boolean showNotification)
       throws FirebaseAppDistributionException {
diff --git a/firebase-app-distribution/src/test/java/com/google/firebase/app/distribution/ApkUpdaterTest.java b/firebase-app-distribution/src/test/java/com/google/firebase/app/distribution/ApkUpdaterTest.java
@@ -187,8 +187,6 @@ public void updateApk_whenInstallFailed_setsError() {
     verify(mockNotificationsManager).updateNotification(1000, 1000, UpdateStatus.INSTALL_FAILED);
   }
 
-  // TODO(lkellogg): Improve these notification related tests so they actually assert that the
-  //  correct notifications are set under various conditions.
   @Test
   public void updateApk_showNotificationFalse_doesNotUpdateNotificationManager() {
     boolean showNotification = false;

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,6 @@ Task<File> downloadApk(`
`152`	`152`	`return downloadTaskCompletionSource.getTask();`
`153`	`153`	`}`
`154`	`154`
`155`		`- // TODO(lkellogg): The happy path in this method is not exercised by any tests right now`
`156`	`155`	`private void makeApkDownloadRequest(`
`157`	`156`	`@NonNull AppDistributionReleaseInternal newRelease, boolean showNotification)`
`158`	`157`	`throws FirebaseAppDistributionException {`
Original file line number	Diff line number	Diff line change
`@@ -187,8 +187,6 @@ public void updateApk_whenInstallFailed_setsError() {`
`187`	`187`	`verify(mockNotificationsManager).updateNotification(1000, 1000, UpdateStatus.INSTALL_FAILED);`
`188`	`188`	`}`
`189`	`189`
`190`		`- // TODO(lkellogg): Improve these notification related tests so they actually assert that the`
`191`		`- // correct notifications are set under various conditions.`
`192`	`190`	`@Test`
`193`	`191`	`public void updateApk_showNotificationFalse_doesNotUpdateNotificationManager() {`
`194`	`192`	`boolean showNotification = false;`