Skip to content

Commit 2dc0264

Browse files
committed
Address comments #1
1 parent 1c77a31 commit 2dc0264

File tree

3 files changed

+15
-9
lines changed

3 files changed

+15
-9
lines changed

firebase-segmentation/firebase-segmentation.gradle

+12-6
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@ plugins {
1717
id 'com.google.protobuf'
1818
}
1919

20+
firebaseLibrary {
21+
testLab.enabled = true
22+
}
23+
2024
protobuf {
2125
// Configure the protoc executable
2226
protoc {
@@ -57,7 +61,7 @@ android {
5761
targetSdkVersion project.targetSdkVersion
5862
multiDexEnabled true
5963
versionName version
60-
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
64+
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
6165
}
6266
sourceSets {
6367
main {
@@ -80,16 +84,18 @@ android {
8084
dependencies {
8185
implementation project(':firebase-common')
8286

83-
implementation ('com.google.firebase:firebase-iid:17.0.3') {
87+
implementation('com.google.firebase:firebase-iid:17.0.3') {
8488
exclude group: "com.google.firebase", module: "firebase-common"
8589
}
86-
implementation 'com.android.support:appcompat-v7:28.0.0'
87-
implementation 'com.android.support:multidex:1.0.3'
90+
implementation 'androidx.appcompat:appcompat:1.0.2'
91+
implementation 'androidx.multidex:multidex:2.0.0'
8892
implementation 'com.google.android.gms:play-services-tasks:16.0.1'
8993

90-
testImplementation 'androidx.test:core:1.0.0'
94+
testImplementation 'androidx.test:core:1.2.0'
9195
testImplementation 'junit:junit:4.12'
9296
testImplementation "org.robolectric:robolectric:$robolectricVersion"
9397

94-
androidTestImplementation 'com.android.support.test:runner:1.0.2'
98+
androidTestImplementation 'androidx.annotation:annotation:1.1.0'
99+
androidTestImplementation 'androidx.test:runner:1.2.0'
100+
androidTestImplementation 'androidx.test:rules:1.2.0'
95101
}

firebase-segmentation/src/androidTest/AndroidManifest.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,6 @@
2121
</application>
2222

2323
<instrumentation
24-
android:name="android.support.test.runner.AndroidJUnitRunner"
24+
android:name="androidx.test.runner.AndroidJUnitRunner"
2525
android:targetPackage="com.google.firebase.segmentation" />
2626
</manifest>

firebase-segmentation/src/androidTest/java/com/google/firebase/segmentation/FirebaseSegmentationInstrumentedTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
package com.google.firebase.segmentation;
1616

17-
import static org.junit.Assert.assertNotNull;
17+
import static org.junit.Assert.assertNull;
1818

1919
import androidx.test.InstrumentationRegistry;
2020
import androidx.test.runner.AndroidJUnit4;
@@ -45,6 +45,6 @@ public void setUp() {
4545

4646
@Test
4747
public void useAppContext() {
48-
assertNotNull(FirebaseSegmentation.getInstance().setCustomInstallationId("123123").getResult());
48+
assertNull(FirebaseSegmentation.getInstance().setCustomInstallationId("123123").getResult());
4949
}
5050
}

0 commit comments

Comments
 (0)