Fix wrong "should start" check in RemoteStore (watch instead of write stream) (#88)

var-const · web-flow · commit 2444ad869b79 · 2018-10-25T13:39:47.000-04:00
diff --git a/firebase-firestore/src/main/java/com/google/firebase/firestore/remote/RemoteStore.java b/firebase-firestore/src/main/java/com/google/firebase/firestore/remote/RemoteStore.java
@@ -617,7 +617,7 @@ private void handleWriteStreamClose(Status status) {
     if (Status.OK.equals(status)) {
       // Graceful stop (due to stop() or idle timeout). Make sure that's desirable.
       hardAssert(
-          !shouldStartWatchStream(), "Write stream was stopped gracefully while still needed.");
+          !shouldStartWriteStream(), "Write stream was stopped gracefully while still needed.");
     }
 
     // If the write stream closed due to an error, invoke the error callbacks if there are pending

Original file line number	Diff line number	Diff line change
`@@ -617,7 +617,7 @@ private void handleWriteStreamClose(Status status) {`
`617`	`617`	`if (Status.OK.equals(status)) {`
`618`	`618`	`// Graceful stop (due to stop() or idle timeout). Make sure that's desirable.`
`619`	`619`	`hardAssert(`
`620`		`- !shouldStartWatchStream(), "Write stream was stopped gracefully while still needed.");`
	`620`	`+ !shouldStartWriteStream(), "Write stream was stopped gracefully while still needed.");`
`621`	`621`	`}`
`622`	`622`
`623`	`623`	`// If the write stream closed due to an error, invoke the error callbacks if there are pending`