Skip to content

Commit 23bcd86

Browse files
committed
fix unit tests
1 parent 7036db5 commit 23bcd86

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/CrashlyticsController.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -559,6 +559,8 @@ private void doOpenSession(String sessionIdentifier, Boolean isOnDemand) {
559559
reportingCoordinator.onBeginSession(sessionIdentifier, startedAtSeconds);
560560
}
561561

562+
// This is only used for exception handler close session (we have another close session in
563+
// background initialization)
562564
void doCloseSessions(SettingsProvider settingsProvider) {
563565
doCloseSessions(false, settingsProvider, false);
564566
}

firebase-crashlytics/src/test/java/com/google/firebase/crashlytics/internal/common/CrashlyticsControllerRobolectricTest.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343
import com.google.firebase.crashlytics.internal.settings.SettingsProvider;
4444
import com.google.firebase.inject.Deferred;
4545
import java.util.ArrayList;
46+
import java.util.Arrays;
4647
import java.util.Collections;
4748
import java.util.List;
4849
import java.util.TreeSet;
@@ -100,6 +101,7 @@ public void testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntE
100101

101102
@Test
102103
public void testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists() {
104+
final String sessionIdPrevious = "sessionIdPrevious";
103105
final String sessionId = "sessionId";
104106
final CrashlyticsController controller = createController();
105107
// Adds multiple AppExitInfos to confirm that Crashlytics loops through
@@ -109,12 +111,12 @@ public void testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists() {
109111
List<ApplicationExitInfo> testApplicationExitInfo = getApplicationExitInfoList();
110112

111113
when(mockSessionReportingCoordinator.listSortedOpenSessionIds())
112-
.thenReturn(new TreeSet<>(Collections.singletonList(sessionId)));
114+
.thenReturn(new TreeSet<>(Arrays.asList(sessionId, sessionIdPrevious)));
113115
mockSettingsProvider(true, false);
114-
controller.doCloseSessions(mockSettingsProvider);
116+
controller.finalizeSessions(mockSettingsProvider);
115117
verify(mockSessionReportingCoordinator)
116118
.persistRelevantAppExitInfoEvent(
117-
eq(sessionId),
119+
eq(sessionIdPrevious),
118120
eq(testApplicationExitInfo),
119121
any(LogFileManager.class),
120122
any(UserMetadata.class));

0 commit comments

Comments
 (0)