Address review comments.

vkryachko · vkryachko · commit 1f973dd52e07 · 2022-09-13T11:25:03.000-04:00
diff --git a/buildSrc/build.gradle.kts b/buildSrc/build.gradle.kts
@@ -56,7 +56,6 @@ dependencies {
     implementation("org.apache.maven:maven-aether-provider:3.1.0")
 
     implementation("com.google.code.gson:gson:2.8.9")
-    implementation("org.jetbrains.dokka:dokka-android-gradle-plugin:0.9.17-g013-9b8280a")
     implementation("com.android.tools.build:gradle:7.2.2")
     implementation("com.android.tools.build:builder-test-api:7.2.2")
     implementation("gradle.plugin.com.github.sherter.google-java-format:google-java-format-gradle-plugin:0.9")
diff --git a/encoders/protoc-gen-firebase-encoders/protoc-gen-firebase-encoders.gradle b/encoders/protoc-gen-firebase-encoders/protoc-gen-firebase-encoders.gradle
@@ -28,16 +28,13 @@ protobuf {
 
 kapt {
     generateStubs = false
+    correctErrorTypes = true
 }
 
 jar {
     manifest.attributes "Main-Class": "com.google.firebase.encoders.proto.codegen.MainKt"
 }
 
-kapt {
-    correctErrorTypes = true
-}
-
 dependencies {
 
     implementation "com.google.protobuf:protobuf-java:3.14.0"

Original file line number	Diff line number	Diff line change
`@@ -28,16 +28,13 @@ protobuf {`
`28`	`28`
`29`	`29`	`kapt {`
`30`	`30`	`generateStubs = false`
	`31`	`+ correctErrorTypes = true`
`31`	`32`	`}`
`32`	`33`
`33`	`34`	`jar {`
`34`	`35`	`manifest.attributes "Main-Class": "com.google.firebase.encoders.proto.codegen.MainKt"`
`35`	`36`	`}`
`36`	`37`
`37`		`-kapt {`
`38`		`- correctErrorTypes = true`
`39`		`-}`
`40`		`-`
`41`	`38`	`dependencies {`
`42`	`39`
`43`	`40`	`implementation "com.google.protobuf:protobuf-java:3.14.0"`