Skip to content

Commit 1852c14

Browse files
eldhosembabupull[bot]
authored andcommitted
Removing FIAM Display SDK dependency on Analytics. (#2669)
* Removing FIAM Display SDK dependency on Analytics since its not used by FIAM Display SDK * Changing to use container.get(FirebaseApp.class); instead of FirebaseApp.getInstance();
1 parent 648b832 commit 1852c14

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

firebase-inappmessaging-display/firebase-inappmessaging-display.gradle

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,6 @@ dependencies {
7070
implementation project(':firebase-components')
7171
implementation project(':firebase-inappmessaging')
7272

73-
implementation('com.google.firebase:firebase-measurement-connector:18.0.0') {
74-
exclude group: 'com.google.firebase', module: 'firebase-common'
75-
}
76-
7773
implementation 'com.google.android.gms:play-services-tasks:17.1.0'
7874
implementation 'androidx.appcompat:appcompat:1.1.0'
7975
implementation 'androidx.cardview:cardview:1.0.0'

firebase-inappmessaging-display/src/main/java/com/google/firebase/inappmessaging/display/FirebaseInAppMessagingDisplayRegistrar.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import android.app.Application;
1818
import androidx.annotation.Keep;
1919
import com.google.firebase.FirebaseApp;
20-
import com.google.firebase.analytics.connector.AnalyticsConnector;
2120
import com.google.firebase.components.Component;
2221
import com.google.firebase.components.ComponentContainer;
2322
import com.google.firebase.components.ComponentRegistrar;
@@ -46,7 +45,6 @@ public List<Component<?>> getComponents() {
4645
return Arrays.asList(
4746
Component.builder(FirebaseInAppMessagingDisplay.class)
4847
.add(Dependency.required(FirebaseApp.class))
49-
.add(Dependency.required(AnalyticsConnector.class))
5048
.add(Dependency.required(FirebaseInAppMessaging.class))
5149
.factory(this::buildFirebaseInAppMessagingUI)
5250
.eagerInDefaultApp()
@@ -56,7 +54,7 @@ public List<Component<?>> getComponents() {
5654

5755
private FirebaseInAppMessagingDisplay buildFirebaseInAppMessagingUI(
5856
ComponentContainer container) {
59-
FirebaseApp firebaseApp = FirebaseApp.getInstance();
57+
FirebaseApp firebaseApp = container.get(FirebaseApp.class);
6058
FirebaseInAppMessaging headless = container.get(FirebaseInAppMessaging.class);
6159
Application firebaseApplication = (Application) firebaseApp.getApplicationContext();
6260

0 commit comments

Comments
 (0)