Skip to content

Commit 17e511c

Browse files
committed
PR feedback
1 parent 8f8c66a commit 17e511c

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

firebase-database/src/androidTest/java/com/google/firebase/database/DataTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2352,7 +2352,7 @@ public void onComplete(DatabaseError error, DatabaseReference ref) {
23522352
assertEquals(snap.getPriority().getClass(), Double.class);
23532353
assertEquals(snap.getPriority(), snap.child("b").getPriority());
23542354
assertEquals(snap.child("a").getValue(), snap.child("b").getValue());
2355-
Long drift = System.currentTimeMillis() - Long.parseLong(snap.child("a").getValue().toString());
2355+
long drift = System.currentTimeMillis() - Long.parseLong(snap.child("a").getValue().toString());
23562356
assertThat(Math.abs(drift), lessThan(2000l));
23572357
}
23582358

firebase-database/src/test/java/com/google/firebase/database/MapperTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
@org.junit.runner.RunWith(RobolectricTestRunner.class)
3838
@Config(manifest = Config.NONE)
3939
public class MapperTest {
40-
private static final double EPISLON = 0.00025f;
40+
private static final double EPSILON = 0.00025f;
4141

4242
private static class StringBean {
4343
private String value;
@@ -949,14 +949,14 @@ public void primitiveDeserializeBoolean() {
949949
@Test
950950
public void primitiveDeserializeDouble() {
951951
DoubleBean beanDouble = deserialize("{'value': 1.1}", DoubleBean.class);
952-
assertEquals(1.1, beanDouble.value, EPISLON);
952+
assertEquals(1.1, beanDouble.value, EPSILON);
953953

954954
// Int
955955
DoubleBean beanInt = deserialize("{'value': 1}", DoubleBean.class);
956-
assertEquals(1, beanInt.value, EPISLON);
956+
assertEquals(1, beanInt.value, EPSILON);
957957
// Long
958958
DoubleBean beanLong = deserialize("{'value': 1234567890123}", DoubleBean.class);
959-
assertEquals(1234567890123L, beanLong.value, EPISLON);
959+
assertEquals(1234567890123L, beanLong.value, EPSILON);
960960

961961
// Boolean
962962
try {
@@ -976,14 +976,14 @@ public void primitiveDeserializeDouble() {
976976
@Test
977977
public void primitiveDeserializeFloat() {
978978
FloatBean beanFloat = deserialize("{'value': 1.1}", FloatBean.class);
979-
assertEquals(1.1, beanFloat.value, EPISLON);
979+
assertEquals(1.1, beanFloat.value, EPSILON);
980980

981981
// Int
982982
FloatBean beanInt = deserialize("{'value': 1}", FloatBean.class);
983-
assertEquals(1, beanInt.value, EPISLON);
983+
assertEquals(1, beanInt.value, EPSILON);
984984
// Long
985985
FloatBean beanLong = deserialize("{'value': 1234567890123}", FloatBean.class);
986-
assertEquals(Long.valueOf(1234567890123L).floatValue(), beanLong.value, EPISLON);
986+
assertEquals(Long.valueOf(1234567890123L).floatValue(), beanLong.value, EPSILON);
987987

988988
// Boolean
989989
try {

0 commit comments

Comments
 (0)