Revert "Fix tests that failed in test lab"

mrober · mrober · commit 0eaa4b4c3f26 · 2024-07-29T12:07:19.000-04:00
This reverts commit 9eda4b2.
diff --git a/firebase-crashlytics/src/androidTest/java/com/google/firebase/crashlytics/internal/metadata/MetaDataStoreTest.java b/firebase-crashlytics/src/androidTest/java/com/google/firebase/crashlytics/internal/metadata/MetaDataStoreTest.java
@@ -104,10 +104,9 @@ public void testWriteUserData_null() {
     assertNull(userData.getUserId());
   }
 
-  public void testWriteUserData_emptyString() throws Exception {
+  public void testWriteUserData_emptyString() {
     storeUnderTest.writeUserData(SESSION_ID_1, metadataWithUserId(SESSION_ID_1, "").getUserId());
     UserMetadata userData = UserMetadata.loadFromExistingSession(SESSION_ID_1, fileStore, worker);
-    worker.await();
     assertEquals("", userData.getUserId());
   }
 
@@ -118,11 +117,10 @@ public void testWriteUserData_unicode() {
     assertEquals(UNICODE, userData.getUserId());
   }
 
-  public void testWriteUserData_escaped() throws Exception {
+  public void testWriteUserData_escaped() {
     storeUnderTest.writeUserData(
         SESSION_ID_1, metadataWithUserId(SESSION_ID_1, ESCAPED).getUserId());
     UserMetadata userData = UserMetadata.loadFromExistingSession(SESSION_ID_1, fileStore, worker);
-    worker.await();
     assertEquals(ESCAPED.trim(), userData.getUserId());
   }
 

Original file line number	Diff line number	Diff line change
`@@ -104,10 +104,9 @@ public void testWriteUserData_null() {`
`104`	`104`	`assertNull(userData.getUserId());`
`105`	`105`	`}`
`106`	`106`
`107`		`- public void testWriteUserData_emptyString() throws Exception {`
	`107`	`+ public void testWriteUserData_emptyString() {`
`108`	`108`	`storeUnderTest.writeUserData(SESSION_ID_1, metadataWithUserId(SESSION_ID_1, "").getUserId());`
`109`	`109`	`UserMetadata userData = UserMetadata.loadFromExistingSession(SESSION_ID_1, fileStore, worker);`
`110`		`- worker.await();`
`111`	`110`	`assertEquals("", userData.getUserId());`
`112`	`111`	`}`
`113`	`112`
`@@ -118,11 +117,10 @@ public void testWriteUserData_unicode() {`
`118`	`117`	`assertEquals(UNICODE, userData.getUserId());`
`119`	`118`	`}`
`120`	`119`
`121`		`- public void testWriteUserData_escaped() throws Exception {`
	`120`	`+ public void testWriteUserData_escaped() {`
`122`	`121`	`storeUnderTest.writeUserData(`
`123`	`122`	`SESSION_ID_1, metadataWithUserId(SESSION_ID_1, ESCAPED).getUserId());`
`124`	`123`	`UserMetadata userData = UserMetadata.loadFromExistingSession(SESSION_ID_1, fileStore, worker);`
`125`		`- worker.await();`
`126`	`124`	`assertEquals(ESCAPED.trim(), userData.getUserId());`
`127`	`125`	`}`
`128`	`126`