Skip to content

Commit 0b61832

Browse files
authored
Move all the gauges related classes to its own package. (#2534)
1 parent 00e9d49 commit 0b61832

19 files changed

+43
-25
lines changed

firebase-perf/src/main/java/com/google/firebase/perf/FirebasePerformance.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
import com.google.firebase.perf.metrics.HttpMetric;
3535
import com.google.firebase.perf.metrics.Trace;
3636
import com.google.firebase.perf.metrics.validator.PerfMetricValidator;
37-
import com.google.firebase.perf.session.GaugeManager;
37+
import com.google.firebase.perf.session.gauges.GaugeManager;
3838
import com.google.firebase.perf.transport.TransportManager;
3939
import com.google.firebase.perf.util.Constants;
4040
import com.google.firebase.perf.util.ImmutableBundle;

firebase-perf/src/main/java/com/google/firebase/perf/injection/modules/FirebasePerformanceModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
import com.google.firebase.perf.FirebasePerformance;
2323
import com.google.firebase.perf.config.ConfigResolver;
2424
import com.google.firebase.perf.config.RemoteConfigManager;
25-
import com.google.firebase.perf.session.GaugeManager;
25+
import com.google.firebase.perf.session.gauges.GaugeManager;
2626
import com.google.firebase.remoteconfig.RemoteConfigComponent;
2727
import dagger.Module;
2828
import dagger.Provides;

firebase-perf/src/main/java/com/google/firebase/perf/metrics/NetworkRequestMetricBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121
import com.google.firebase.perf.application.AppStateMonitor;
2222
import com.google.firebase.perf.application.AppStateUpdateHandler;
2323
import com.google.firebase.perf.logging.AndroidLogger;
24-
import com.google.firebase.perf.session.GaugeManager;
2524
import com.google.firebase.perf.session.PerfSession;
2625
import com.google.firebase.perf.session.SessionAwareObject;
2726
import com.google.firebase.perf.session.SessionManager;
27+
import com.google.firebase.perf.session.gauges.GaugeManager;
2828
import com.google.firebase.perf.transport.TransportManager;
2929
import com.google.firebase.perf.util.Constants;
3030
import com.google.firebase.perf.util.Timer;

firebase-perf/src/main/java/com/google/firebase/perf/metrics/Trace.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@
2626
import com.google.firebase.perf.config.ConfigResolver;
2727
import com.google.firebase.perf.logging.AndroidLogger;
2828
import com.google.firebase.perf.metrics.validator.PerfMetricValidator;
29-
import com.google.firebase.perf.session.GaugeManager;
3029
import com.google.firebase.perf.session.PerfSession;
3130
import com.google.firebase.perf.session.SessionAwareObject;
3231
import com.google.firebase.perf.session.SessionManager;
32+
import com.google.firebase.perf.session.gauges.GaugeManager;
3333
import com.google.firebase.perf.transport.TransportManager;
3434
import com.google.firebase.perf.util.Clock;
3535
import com.google.firebase.perf.util.Constants;

firebase-perf/src/main/java/com/google/firebase/perf/session/SessionManager.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import com.google.android.gms.common.util.VisibleForTesting;
2020
import com.google.firebase.perf.application.AppStateMonitor;
2121
import com.google.firebase.perf.application.AppStateUpdateHandler;
22+
import com.google.firebase.perf.session.gauges.GaugeManager;
2223
import com.google.firebase.perf.v1.ApplicationProcessState;
2324
import com.google.firebase.perf.v1.GaugeMetadata;
2425
import com.google.firebase.perf.v1.GaugeMetric;

firebase-perf/src/main/java/com/google/firebase/perf/session/collectors/CpuGaugeCollector.java renamed to firebase-perf/src/main/java/com/google/firebase/perf/session/gauges/CpuGaugeCollector.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.session.collectors;
15+
package com.google.firebase.perf.session.gauges;
1616

1717
import static android.system.Os.sysconf;
1818

firebase-perf/src/main/java/com/google/firebase/perf/session/GaugeManager.java renamed to firebase-perf/src/main/java/com/google/firebase/perf/session/gauges/GaugeManager.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,15 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.session;
15+
package com.google.firebase.perf.session.gauges;
1616

1717
import android.content.Context;
1818
import androidx.annotation.Keep;
1919
import androidx.annotation.Nullable;
2020
import androidx.annotation.VisibleForTesting;
2121
import com.google.firebase.perf.config.ConfigResolver;
2222
import com.google.firebase.perf.logging.AndroidLogger;
23-
import com.google.firebase.perf.session.collectors.CpuGaugeCollector;
24-
import com.google.firebase.perf.session.collectors.MemoryGaugeCollector;
23+
import com.google.firebase.perf.session.PerfSession;
2524
import com.google.firebase.perf.transport.TransportManager;
2625
import com.google.firebase.perf.util.Timer;
2726
import com.google.firebase.perf.v1.AndroidMemoryReading;
@@ -253,7 +252,7 @@ private void syncFlush(String sessionId, ApplicationProcessState appState) {
253252
* @param appState The {@link ApplicationProcessState} for which these gauges are collected.
254253
* @return true if GaugeMetadata was logged, false otherwise.
255254
*/
256-
boolean logGaugeMetadata(String sessionId, ApplicationProcessState appState) {
255+
public boolean logGaugeMetadata(String sessionId, ApplicationProcessState appState) {
257256
if (gaugeMetadataManager != null) {
258257
GaugeMetric gaugeMetric =
259258
GaugeMetric.newBuilder()

firebase-perf/src/main/java/com/google/firebase/perf/session/GaugeMetadataManager.java renamed to firebase-perf/src/main/java/com/google/firebase/perf/session/gauges/GaugeMetadataManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.session;
15+
package com.google.firebase.perf.session.gauges;
1616

1717
import android.app.ActivityManager;
1818
import android.app.ActivityManager.MemoryInfo;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.session.collectors;
15+
package com.google.firebase.perf.session.gauges;
1616

1717
import android.annotation.SuppressLint;
1818
import androidx.annotation.Nullable;
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
// Copyright 2021 Google LLC
2+
//
3+
// Licensed under the Apache License, Version 2.0 (the "License");
4+
// you may not use this file except in compliance with the License.
5+
// You may obtain a copy of the License at
6+
//
7+
// http://www.apache.org/licenses/LICENSE-2.0
8+
//
9+
// Unless required by applicable law or agreed to in writing, software
10+
// distributed under the License is distributed on an "AS IS" BASIS,
11+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
// See the License for the specific language governing permissions and
13+
// limitations under the License.
14+
15+
/** @hide */
16+
/** @hide */
17+
package com.google.firebase.perf.session.gauges;
18+

firebase-perf/src/test/java/com/google/firebase/perf/FirebasePerformanceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
import com.google.firebase.perf.config.ConfigResolver;
3636
import com.google.firebase.perf.config.DeviceCacheManager;
3737
import com.google.firebase.perf.config.RemoteConfigManager;
38-
import com.google.firebase.perf.session.GaugeManager;
38+
import com.google.firebase.perf.session.gauges.GaugeManager;
3939
import com.google.firebase.perf.util.Constants;
4040
import com.google.firebase.perf.util.ImmutableBundle;
4141
import com.google.firebase.remoteconfig.RemoteConfigComponent;

firebase-perf/src/test/java/com/google/firebase/perf/application/AppStateMonitorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
import com.google.firebase.perf.config.DeviceCacheManager;
3838
import com.google.firebase.perf.metrics.NetworkRequestMetricBuilder;
3939
import com.google.firebase.perf.metrics.Trace;
40-
import com.google.firebase.perf.session.GaugeManager;
40+
import com.google.firebase.perf.session.gauges.GaugeManager;
4141
import com.google.firebase.perf.transport.TransportManager;
4242
import com.google.firebase.perf.util.Clock;
4343
import com.google.firebase.perf.util.Constants;

firebase-perf/src/test/java/com/google/firebase/perf/metrics/NetworkRequestMetricBuilderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@
2222

2323
import com.google.firebase.perf.FirebasePerformanceTestBase;
2424
import com.google.firebase.perf.application.AppStateMonitor;
25-
import com.google.firebase.perf.session.GaugeManager;
2625
import com.google.firebase.perf.session.PerfSession;
2726
import com.google.firebase.perf.session.SessionManager;
27+
import com.google.firebase.perf.session.gauges.GaugeManager;
2828
import com.google.firebase.perf.transport.TransportManager;
2929
import com.google.firebase.perf.util.Constants;
3030
import com.google.firebase.perf.util.Timer;

firebase-perf/src/test/java/com/google/firebase/perf/metrics/TraceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@
3232
import com.google.firebase.perf.application.AppStateMonitor;
3333
import com.google.firebase.perf.config.ConfigResolver;
3434
import com.google.firebase.perf.config.DeviceCacheManager;
35-
import com.google.firebase.perf.session.GaugeManager;
3635
import com.google.firebase.perf.session.PerfSession;
3736
import com.google.firebase.perf.session.SessionManager;
37+
import com.google.firebase.perf.session.gauges.GaugeManager;
3838
import com.google.firebase.perf.transport.TransportManager;
3939
import com.google.firebase.perf.util.Clock;
4040
import com.google.firebase.perf.util.Constants;

firebase-perf/src/test/java/com/google/firebase/perf/session/SessionManagerTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727

2828
import com.google.firebase.perf.FirebasePerformanceTestBase;
2929
import com.google.firebase.perf.application.AppStateMonitor;
30+
import com.google.firebase.perf.session.gauges.GaugeManager;
3031
import com.google.firebase.perf.v1.ApplicationProcessState;
3132
import java.lang.ref.WeakReference;
3233
import org.junit.Before;
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.session.collectors;
15+
package com.google.firebase.perf.session.gauges;
1616

1717
import static com.google.common.truth.Truth.assertThat;
1818
import static java.nio.charset.StandardCharsets.UTF_8;
@@ -34,7 +34,7 @@
3434
import org.robolectric.RobolectricTestRunner;
3535
import org.robolectric.shadows.ShadowEnvironment;
3636

37-
/** Unit tests for {@link com.google.firebase.perf.session.collectors.CpuGaugeCollector} */
37+
/** Unit tests for {@link com.google.firebase.perf.session.gauges.CpuGaugeCollector} */
3838
@RunWith(RobolectricTestRunner.class)
3939
public final class CpuGaugeCollectorTest {
4040
private static final long MICROSECONDS_PER_SECOND = TimeUnit.SECONDS.toMicros(1);

firebase-perf/src/test/java/com/google/firebase/perf/session/GaugeManagerTest.java renamed to firebase-perf/src/test/java/com/google/firebase/perf/session/gauges/GaugeManagerTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.session;
15+
package com.google.firebase.perf.session.gauges;
1616

1717
import static com.google.common.truth.Truth.assertThat;
1818
import static org.mockito.ArgumentMatchers.eq;
@@ -28,8 +28,7 @@
2828

2929
import com.google.firebase.perf.FirebasePerformanceTestBase;
3030
import com.google.firebase.perf.config.ConfigResolver;
31-
import com.google.firebase.perf.session.collectors.CpuGaugeCollector;
32-
import com.google.firebase.perf.session.collectors.MemoryGaugeCollector;
31+
import com.google.firebase.perf.session.PerfSession;
3332
import com.google.firebase.perf.transport.TransportManager;
3433
import com.google.firebase.perf.util.Clock;
3534
import com.google.firebase.perf.util.Timer;
@@ -48,7 +47,7 @@
4847
import org.robolectric.RobolectricTestRunner;
4948
import org.robolectric.RuntimeEnvironment;
5049

51-
/** Unit tests for {@link GaugeManager} */
50+
/** Unit tests for {@link com.google.firebase.perf.session.gauges.GaugeManager} */
5251
@RunWith(RobolectricTestRunner.class)
5352
public final class GaugeManagerTest extends FirebasePerformanceTestBase {
5453

firebase-perf/src/test/java/com/google/firebase/perf/session/GaugeMetadataManagerTest.java renamed to firebase-perf/src/test/java/com/google/firebase/perf/session/gauges/GaugeMetadataManagerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.session;
15+
package com.google.firebase.perf.session.gauges;
1616

1717
import static com.google.common.truth.Truth.assertThat;
1818
import static java.nio.charset.StandardCharsets.UTF_8;
@@ -41,7 +41,7 @@
4141
import org.robolectric.RuntimeEnvironment;
4242
import org.robolectric.shadows.ShadowEnvironment;
4343

44-
/** Unit tests for {@link com.google.firebase.perf.session.GaugeMetadataManager} */
44+
/** Unit tests for {@link com.google.firebase.perf.session.gauges.GaugeMetadataManager} */
4545
@RunWith(RobolectricTestRunner.class)
4646
public class GaugeMetadataManagerTest extends FirebasePerformanceTestBase {
4747

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.session.collectors;
15+
package com.google.firebase.perf.session.gauges;
1616

1717
import static com.google.common.truth.Truth.assertThat;
1818
import static org.mockito.MockitoAnnotations.initMocks;
@@ -29,7 +29,7 @@
2929
import org.mockito.Mock;
3030
import org.robolectric.RobolectricTestRunner;
3131

32-
/** Unit tests for {@link com.google.firebase.perf.session.collectors.MemoryGaugeCollector} */
32+
/** Unit tests for {@link com.google.firebase.perf.session.gauges.MemoryGaugeCollector} */
3333
@RunWith(RobolectricTestRunner.class)
3434
public class MemoryGaugeCollectorTest {
3535

0 commit comments

Comments
 (0)