Remove Dokka Plugin (#4031)

* Remove DackkaPlugin from register block

This doesn't currently need to be public, as it automatically gets applied via FirebaseLibrary.

* Remove Dokka Pugin

Now that the Dackka plugin is implemented, we can safely remove our previous Dokka plugin.

* Added empty kotlindoc to JavaPlugin for tests

* Removed Dokka from JavadocPlugin

Author: daymxn

buildSrc/build.gradle.kts

@@ -57,7 +57,6 @@ dependencies {
     implementation("org.apache.maven:maven-aether-provider:3.1.0")
 
     implementation("com.google.code.gson:gson:2.8.9")
-    implementation("org.jetbrains.dokka:dokka-android-gradle-plugin:0.9.17-g013-9b8280a")
     implementation("com.android.tools.build:gradle:3.4.3")
     implementation("gradle.plugin.com.github.sherter.google-java-format:google-java-format-gradle-plugin:0.9")
 
@@ -72,10 +71,6 @@ gradlePlugin {
             id = "LicenseResolverPlugin"
             implementationClass = "com.google.firebase.gradle.plugins.license.LicenseResolverPlugin"
         }
-        register("dackkaPlugin") {
-            id = "DackkaPlugin"
-            implementationClass = "com.google.firebase.gradle.plugins.DackkaPlugin"
-        }
         register("multiProjectReleasePlugin") {
             id = "MultiProjectReleasePlugin"
             implementationClass = "com.google.firebase.gradle.MultiProjectReleasePlugin"
@@ -88,12 +83,10 @@ gradlePlugin {
             id = "firebase-library"
             implementationClass = "com.google.firebase.gradle.plugins.FirebaseLibraryPlugin"
         }
-
         register("firebaseJavaLibraryPlugin") {
             id = "firebase-java-library"
             implementationClass = "com.google.firebase.gradle.plugins.FirebaseJavaLibraryPlugin"
         }
-
         register("firebaseVendorPlugin") {
             id = "firebase-vendor"
             implementationClass = "com.google.firebase.gradle.plugins.VendorPlugin"

buildSrc/src/main/java/com/google/firebase/gradle/plugins/Dokka.java

@@ -55,7 +55,7 @@ public void apply(Project project) {
                         ImmutableList.of("-module-name", kotlinModuleName(project))));
 
     setupStaticAnalysis(project, firebaseLibrary);
-    project.afterEvaluate(p -> Dokka.configure(project, null, firebaseLibrary));
+    project.getTasks().register("kotlindoc");
   }
 
   private static void setupStaticAnalysis(Project project, FirebaseLibraryExtension library) {

buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseJavaLibraryPlugin.java

@@ -18,7 +18,6 @@
 
 import com.android.build.gradle.LibraryExtension;
 import com.google.common.collect.ImmutableList;
-import com.google.common.collect.ImmutableMap;
 import java.io.File;
 import java.io.IOException;
 import java.util.List;
@@ -34,8 +33,6 @@
 import org.gradle.api.tasks.javadoc.Javadoc;
 import org.gradle.external.javadoc.CoreJavadocOptions;
 import org.gradle.external.javadoc.StandardJavadocDocletOptions;
-import org.jetbrains.dokka.gradle.DokkaAndroidPlugin;
-import org.jetbrains.dokka.gradle.DokkaTask;
 
 /**
  * This plugin modifies the java plugin's javadoc task to be firebase friendly. It does the
@@ -73,10 +70,10 @@ public void apply(Project project) {
               toBoolean(
                   ((Map<String, Object>) project.getProperties())
                       .getOrDefault("includeFireEscapeArtifacts", "false"));
-          if (!ext.publishJavadoc || !includeFireEscapeArtifacts) {
+          boolean isKotlinAndroid = project.getPlugins().hasPlugin("kotlin-android");
+
+          if (!ext.publishJavadoc || !includeFireEscapeArtifacts || isKotlinAndroid) {
             applyDummyJavadoc(project);
-          } else if (project.getPlugins().hasPlugin("kotlin-android")) {
-            applyDokka(project);
           } else {
             applyDoclava(project);
           }
@@ -276,13 +273,6 @@ private static void applyDoclava(Project project) {
             });
   }
 
-  private static void applyDokka(Project project) {
-    project.apply(ImmutableMap.of("plugin", DokkaAndroidPlugin.class));
-    DokkaTask dokka = (DokkaTask) project.getTasks().getByName("dokka");
-    dokka.setOutputDirectory(project.getBuildDir() + "/docs/javadoc/reference");
-    applyDummyJavadoc(project).dependsOn(dokka);
-  }
-
   private static Task applyDummyJavadoc(Project project) {
     return project
         .getTasks()