Skip to content

Commit bba61e1

Browse files
authored
Upgraded Typescript to 3.7.x (#720)
* Upgraded Typescript to 3.7.x * Removing typeof * Made pollCallback optional
1 parent 375c4fb commit bba61e1

File tree

3 files changed

+18
-35
lines changed

3 files changed

+18
-35
lines changed

package-lock.json

Lines changed: 14 additions & 31 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
"types": "./lib/index.d.ts",
5656
"dependencies": {
5757
"@firebase/database": "^0.5.11",
58-
"@types/node": "^8.0.53",
58+
"@types/node": "^8.10.59",
5959
"dicer": "^0.3.0",
6060
"jsonwebtoken": "8.1.0",
6161
"node-forge": "0.7.4"
@@ -111,7 +111,7 @@
111111
"ts-node": "^3.3.0",
112112
"tslint": "^5.17.0",
113113
"typedoc": "^0.15.0",
114-
"typescript": "^3.1.0",
114+
"typescript": "^3.7.3",
115115
"yargs": "^13.2.2"
116116
}
117117
}

src/utils/api-request.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -912,7 +912,7 @@ export class ExponentialBackoffPoller extends EventEmitter {
912912
private masterTimer: NodeJS.Timer;
913913
private repollTimer: NodeJS.Timer;
914914

915-
private pollCallback: () => Promise<object>;
915+
private pollCallback?: () => Promise<object>;
916916
private resolve: (result: object) => void;
917917
private reject: (err: object) => void;
918918

@@ -957,7 +957,7 @@ export class ExponentialBackoffPoller extends EventEmitter {
957957
}
958958

959959
private repoll(): void {
960-
this.pollCallback()
960+
this.pollCallback!()
961961
.then((result) => {
962962
if (this.completed) {
963963
return;

0 commit comments

Comments
 (0)