Skip to content

Commit 45905e4

Browse files
authored
Enable 'strictNullChecks' ts compiler option. (#676)
* Enable 'structNullChecks' ts compiler option. In the majority of cases, I simply turned stuff like this: ``` function fname(param: T) { if (!param) throw Error("invalid param; must not be nullish"); ... } ``` into this: ``` function fname(param: T|null|undefined) { if (!param) throw Error("invalid param; must not be nullish"); ... } ``` A more sensible approach would be eliminate the possibility of null/undef and eliminate the checks too, but that's a bit more involved and this patch is already enormous. But I think these sorts of improvements could be taken advantage of opportunistically as the code is worked on in the future. * Add @firebase/auth-types to dev dependencies And also update @firebase/auth to most recent to match.
1 parent e231560 commit 45905e4

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+547
-423
lines changed

package-lock.json

Lines changed: 29 additions & 73 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@
6767
"devDependencies": {
6868
"@firebase/app": "^0.4.23",
6969
"@firebase/auth": "^0.12.4",
70+
"@firebase/auth-types": "^0.8.2",
7071
"@types/bcrypt": "^2.0.0",
7172
"@types/chai": "^3.4.34",
7273
"@types/chai-as-promised": "0.0.29",

0 commit comments

Comments
 (0)