From a8d3de0c91c614ab495a1785a53a6e76f4c955f0 Mon Sep 17 00:00:00 2001 From: Vedran Pavic Date: Fri, 23 Jun 2023 10:41:36 +0200 Subject: [PATCH] Mark `sendAll` and `sendMulticast` variants as deprecated In d1baee36 all `sendAll` and `sendMulticast` variants were deprecated, however those methods were marked as deprecated only in javadoc but not using `@Deprecated`. This commit adds `@Deprecated` annotation where needed, in order to better signal the deprecation to developers. --- .../com/google/firebase/messaging/FirebaseMessaging.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/main/java/com/google/firebase/messaging/FirebaseMessaging.java b/src/main/java/com/google/firebase/messaging/FirebaseMessaging.java index 882fec8fc..e16b6ac9d 100644 --- a/src/main/java/com/google/firebase/messaging/FirebaseMessaging.java +++ b/src/main/java/com/google/firebase/messaging/FirebaseMessaging.java @@ -344,6 +344,7 @@ public ApiFuture sendEachForMulticastAsync( * value. * @deprecated Use {@link #sendEach(List)} instead. */ + @Deprecated public BatchResponse sendAll( @NonNull List messages) throws FirebaseMessagingException { return sendAll(messages, false); @@ -371,6 +372,7 @@ public BatchResponse sendAll( * value. * @deprecated Use {@link #sendEach(List, boolean)} instead. */ + @Deprecated public BatchResponse sendAll( @NonNull List messages, boolean dryRun) throws FirebaseMessagingException { return sendAllOp(messages, dryRun).call(); @@ -384,6 +386,7 @@ public BatchResponse sendAll( * the messages have been sent. * @deprecated Use {@link #sendEachAsync(List)} instead. */ + @Deprecated public ApiFuture sendAllAsync(@NonNull List messages) { return sendAllAsync(messages, false); } @@ -397,6 +400,7 @@ public ApiFuture sendAllAsync(@NonNull List messages) { * the messages have been sent, or when the emulation has finished. * @deprecated Use {@link #sendEachAsync(List, boolean)} instead. */ + @Deprecated public ApiFuture sendAllAsync( @NonNull List messages, boolean dryRun) { return sendAllOp(messages, dryRun).callAsync(app); @@ -418,6 +422,7 @@ public ApiFuture sendAllAsync( * return value. * @deprecated Use {@link #sendEachForMulticast(MulticastMessage)} instead. */ + @Deprecated public BatchResponse sendMulticast( @NonNull MulticastMessage message) throws FirebaseMessagingException { return sendMulticast(message, false); @@ -445,6 +450,7 @@ public BatchResponse sendMulticast( * return value. * @deprecated Use {@link #sendEachForMulticast(MulticastMessage, boolean)} instead. */ + @Deprecated public BatchResponse sendMulticast( @NonNull MulticastMessage message, boolean dryRun) throws FirebaseMessagingException { checkNotNull(message, "multicast message must not be null"); @@ -460,6 +466,7 @@ public BatchResponse sendMulticast( * the messages have been sent. * @deprecated Use {@link #sendEachForMulticastAsync(MulticastMessage)} instead. */ + @Deprecated public ApiFuture sendMulticastAsync(@NonNull MulticastMessage message) { return sendMulticastAsync(message, false); } @@ -474,6 +481,7 @@ public ApiFuture sendMulticastAsync(@NonNull MulticastMessage mes * the messages have been sent. * @deprecated Use {@link #sendEachForMulticastAsync(MulticastMessage, boolean)} instead. */ + @Deprecated public ApiFuture sendMulticastAsync( @NonNull MulticastMessage message, boolean dryRun) { checkNotNull(message, "multicast message must not be null");