Skip to content

Commit 2dcd91a

Browse files
Mark sendAll and sendMulticast variants as deprecated (#836)
In d1baee3 all `sendAll` and `sendMulticast` variants were deprecated, however those methods were marked as deprecated only in javadoc but not using `@Deprecated`. This commit adds `@Deprecated` annotation where needed, in order to better signal the deprecation to developers. Co-authored-by: Lahiru Maramba <[email protected]>
1 parent a7ce4c3 commit 2dcd91a

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/main/java/com/google/firebase/messaging/FirebaseMessaging.java

+8
Original file line numberDiff line numberDiff line change
@@ -344,6 +344,7 @@ public ApiFuture<BatchResponse> sendEachForMulticastAsync(
344344
* value.
345345
* @deprecated Use {@link #sendEach(List)} instead.
346346
*/
347+
@Deprecated
347348
public BatchResponse sendAll(
348349
@NonNull List<Message> messages) throws FirebaseMessagingException {
349350
return sendAll(messages, false);
@@ -371,6 +372,7 @@ public BatchResponse sendAll(
371372
* value.
372373
* @deprecated Use {@link #sendEach(List, boolean)} instead.
373374
*/
375+
@Deprecated
374376
public BatchResponse sendAll(
375377
@NonNull List<Message> messages, boolean dryRun) throws FirebaseMessagingException {
376378
return sendAllOp(messages, dryRun).call();
@@ -384,6 +386,7 @@ public BatchResponse sendAll(
384386
* the messages have been sent.
385387
* @deprecated Use {@link #sendEachAsync(List)} instead.
386388
*/
389+
@Deprecated
387390
public ApiFuture<BatchResponse> sendAllAsync(@NonNull List<Message> messages) {
388391
return sendAllAsync(messages, false);
389392
}
@@ -397,6 +400,7 @@ public ApiFuture<BatchResponse> sendAllAsync(@NonNull List<Message> messages) {
397400
* the messages have been sent, or when the emulation has finished.
398401
* @deprecated Use {@link #sendEachAsync(List, boolean)} instead.
399402
*/
403+
@Deprecated
400404
public ApiFuture<BatchResponse> sendAllAsync(
401405
@NonNull List<Message> messages, boolean dryRun) {
402406
return sendAllOp(messages, dryRun).callAsync(app);
@@ -418,6 +422,7 @@ public ApiFuture<BatchResponse> sendAllAsync(
418422
* return value.
419423
* @deprecated Use {@link #sendEachForMulticast(MulticastMessage)} instead.
420424
*/
425+
@Deprecated
421426
public BatchResponse sendMulticast(
422427
@NonNull MulticastMessage message) throws FirebaseMessagingException {
423428
return sendMulticast(message, false);
@@ -445,6 +450,7 @@ public BatchResponse sendMulticast(
445450
* return value.
446451
* @deprecated Use {@link #sendEachForMulticast(MulticastMessage, boolean)} instead.
447452
*/
453+
@Deprecated
448454
public BatchResponse sendMulticast(
449455
@NonNull MulticastMessage message, boolean dryRun) throws FirebaseMessagingException {
450456
checkNotNull(message, "multicast message must not be null");
@@ -460,6 +466,7 @@ public BatchResponse sendMulticast(
460466
* the messages have been sent.
461467
* @deprecated Use {@link #sendEachForMulticastAsync(MulticastMessage)} instead.
462468
*/
469+
@Deprecated
463470
public ApiFuture<BatchResponse> sendMulticastAsync(@NonNull MulticastMessage message) {
464471
return sendMulticastAsync(message, false);
465472
}
@@ -474,6 +481,7 @@ public ApiFuture<BatchResponse> sendMulticastAsync(@NonNull MulticastMessage mes
474481
* the messages have been sent.
475482
* @deprecated Use {@link #sendEachForMulticastAsync(MulticastMessage, boolean)} instead.
476483
*/
484+
@Deprecated
477485
public ApiFuture<BatchResponse> sendMulticastAsync(
478486
@NonNull MulticastMessage message, boolean dryRun) {
479487
checkNotNull(message, "multicast message must not be null");

0 commit comments

Comments
 (0)