Skip to content

Commit e3d3c0f

Browse files
authored
Merge pull request swiftlang#2822 from spevans/pr_icu67_fix
ICU: Disable a test in preperation for upgrading to ICU67
2 parents 1c1e52a + 42a36ad commit e3d3c0f

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

Tests/Foundation/Tests/TestNSNumber.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1149,10 +1149,10 @@ class TestNSNumber : XCTestCase {
11491149
XCTAssertEqual(NSNumber(value: Double.zero).description(withLocale: Locale(identifier: "en_GB")), "0")
11501150
XCTAssertEqual(NSNumber(value: Double.nan).description(withLocale: Locale(identifier: "en_GB")), "NaN")
11511151
XCTAssertEqual(NSNumber(value: Double.leastNormalMagnitude).description(withLocale: Locale(identifier: "en_GB")), "2.225073858507201E-308")
1152-
// Currently disabled as the latest ICU (62+) which uses Google's dobule-conversion library currently converts Double.leastNonzeroMagnitude to 0
1153-
// although the ICU61 version correctly converted it to 5E-324 - Test left in to check for the bug being fixed in the future.
1152+
// Currently disabled as the latest ICU (62+) which uses Google's double-conversion library currently converts Double.leastNonzeroMagnitude to 0
1153+
// although ICU61 version correctly converted it to 5E-324 - Test left in to check for the bug being fixed in the future.
1154+
// This test works in ICU67 so re-enable it after upgrading.
11541155
//XCTAssertEqual(NSNumber(value: Double.leastNonzeroMagnitude).description(withLocale: Locale(identifier: "en_GB")), "5E-324")
1155-
XCTAssertEqual(NSNumber(value: Double.leastNonzeroMagnitude).description(withLocale: Locale(identifier: "en_GB")), "0E+00")
11561156
XCTAssertEqual(NSNumber(value: 2 * Double.leastNonzeroMagnitude).description(withLocale: Locale(identifier: "en_GB")), "1E-323")
11571157
XCTAssertEqual(NSNumber(value: Double.greatestFiniteMagnitude).description(withLocale: Locale(identifier: "en_GB")), "1.797693134862316E+308")
11581158

@@ -1197,10 +1197,10 @@ class TestNSNumber : XCTestCase {
11971197
XCTAssertEqual(NSNumber(value: Double.zero).description(withLocale: Locale(identifier: "de_DE")), "0")
11981198
XCTAssertEqual(NSNumber(value: Double.nan).description(withLocale: Locale(identifier: "de_DE")), "NaN")
11991199
XCTAssertEqual(NSNumber(value: Double.leastNormalMagnitude).description(withLocale: Locale(identifier: "de_DE")), "2,225073858507201E-308")
1200-
// Currently disabled as the latest ICU (62+) which uses Google's dobule-conversion library currently converts Double.leastNonzeroMagnitude to 0
1201-
// although the ICU61 version correctly converted it to 5E-324 - Test left in to check for the bug being fixed in the future.
1200+
// Currently disabled as the latest ICU (62+) which uses Google's double-conversion library currently converts Double.leastNonzeroMagnitude to 0
1201+
// although ICU61 version correctly converted it to 5E-324 - Test left in to check for the bug being fixed in the future.
1202+
// This test works in ICU67 so re-enable it after upgrading.
12021203
//XCTAssertEqual(NSNumber(value: Double.leastNonzeroMagnitude).description(withLocale: Locale(identifier: "de_DE")), "5E-324")
1203-
XCTAssertEqual(NSNumber(value: Double.leastNonzeroMagnitude).description(withLocale: Locale(identifier: "de_DE")), "0E+00")
12041204
XCTAssertEqual(NSNumber(value: 2 * Double.leastNonzeroMagnitude).description(withLocale: Locale(identifier: "de_DE")), "1E-323")
12051205
XCTAssertEqual(NSNumber(value: Double.greatestFiniteMagnitude).description(withLocale: Locale(identifier: "de_DE")), "1,797693134862316E+308")
12061206
}

0 commit comments

Comments
 (0)