Merge pull request swiftlang#2818 from valeriyvan/CFDateIntervalFormatterLeak

swift-ci · web-flow · commit 305767766543 · 2020-06-19T04:30:05.000-07:00
diff --git a/CoreFoundation/Locale.subproj/CFDateIntervalFormatter.c b/CoreFoundation/Locale.subproj/CFDateIntervalFormatter.c
@@ -132,7 +132,7 @@ static void updateFormatter(CFDateIntervalFormatterRef dif) {
         
         char localeBuffer[100] = {0};
         CFStringGetCString(localeID, localeBuffer, 100, kCFStringEncodingUTF8);
-        
+
         UniChar timeZoneID[100] = {0};
         CFTimeZoneRef timeZone = dif->_timeZone;
         if (timeZone) {
@@ -179,6 +179,7 @@ static void updateFormatter(CFDateIntervalFormatterRef dif) {
 #endif
         
         CFRelease(locale);
+        CFRelease(localeID);
         CFRelease(timeZone);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ static void updateFormatter(CFDateIntervalFormatterRef dif) {`
`132`	`132`
`133`	`133`	`char localeBuffer[100] = {0};`
`134`	`134`	`CFStringGetCString(localeID, localeBuffer, 100, kCFStringEncodingUTF8);`
`135`		`-`
	`135`	`+`
`136`	`136`	`UniChar timeZoneID[100] = {0};`
`137`	`137`	`CFTimeZoneRef timeZone = dif->_timeZone;`
`138`	`138`	`if (timeZone) {`
`@@ -179,6 +179,7 @@ static void updateFormatter(CFDateIntervalFormatterRef dif) {`
`179`	`179`	`#endif`
`180`	`180`
`181`	`181`	`CFRelease(locale);`
	`182`	`+ CFRelease(localeID);`
`182`	`183`	`CFRelease(timeZone);`
`183`	`184`	`}`
`184`	`185`	`}`