ci: bootstrap-local now prioritizes typescript files over JSON

The require() logic by default is not enough; require("file") would pick the json
if there are both a file.ts and file.json. This does not show up in prod because
js files are prioritized over json, but it does show up in bootstrap because we
compile ts in memory and there are no .js file on disk (which require()
could potentially see).

This is necessary for the schema change because schema.json and
schema.ts collides. We should also rename the commands from *-impl.ts to
just *.ts (they were named that way because of this conflict).

Author: hansl

lib/bootstrap-local.js

@@ -126,7 +126,17 @@ if (!__dirname.match(new RegExp(`\\${path.sep}node_modules\\${path.sep}`))) {
         const p = path.join(packages[match].root, request.substr(match.length));
         return oldResolve.call(this, p, parent);
       } else {
-        return oldResolve.apply(this, arguments);
+        // Because loading `.ts` ends up AFTER `.json` in the require() logic, requiring a file that has both `.json`
+        // and `.ts` versions will only get the `.json` content (which wouldn't happen if the .ts was compiled to
+        // JavaScript). We load `.ts` files first here to avoid this conflict. It's hacky, but so is the rest of this
+        // file.
+        const resolvedPath = oldResolve.apply(this, arguments);
+        const maybeTsPath = resolvedPath.endsWith('.json') && resolvedPath.replace(/\.json$/, '.ts');
+        if (maybeTsPath && !request.endsWith('.json') && fs.existsSync(maybeTsPath)) {
+          return maybeTsPath;
+        }
+
+        return resolvedPath;
       }
     }
   };