Skip to content

Commit 302bbb3

Browse files
Broccofilipesilva
authored andcommitted
fix(@schematics/angular): Fix root path for e2e projects during update
1 parent 3296602 commit 302bbb3

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

packages/schematics/angular/migrations/update-6/index.ts

+4-3
Original file line numberDiff line numberDiff line change
@@ -387,8 +387,9 @@ function extractProjectsConfig(
387387
return entry;
388388
}
389389

390+
const projectRoot = join(normalize(appRoot), '..');
390391
const project: JsonObject = {
391-
root: join(normalize(appRoot), '..'),
392+
root: projectRoot,
392393
sourceRoot: appRoot,
393394
projectType: 'application',
394395
};
@@ -538,8 +539,8 @@ function extractProjectsConfig(
538539
architect.server = serverTarget;
539540
}
540541
const e2eProject: JsonObject = {
541-
root: project.root,
542-
sourceRoot: join(project.root as Path, 'e2e'),
542+
root: join(projectRoot, 'e2e'),
543+
sourceRoot: join(projectRoot, 'e2e'),
543544
projectType: 'application',
544545
};
545546

packages/schematics/angular/migrations/update-6/index_spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -659,7 +659,7 @@ describe('Migration to v6', () => {
659659
tree.create(oldConfigPath, JSON.stringify(baseConfig, null, 2));
660660
tree = schematicRunner.runSchematic('migration-01', defaultOptions, tree);
661661
const e2eProject = getConfig(tree).projects['foo-e2e'];
662-
expect(e2eProject.root).toBe('');
662+
expect(e2eProject.root).toBe('e2e');
663663
expect(e2eProject.sourceRoot).toBe('e2e');
664664
const e2eOptions = e2eProject.architect.e2e;
665665
expect(e2eOptions.builder).toEqual('@angular-devkit/build-angular:protractor');
@@ -673,7 +673,7 @@ describe('Migration to v6', () => {
673673
tree.create(oldConfigPath, JSON.stringify(baseConfig, null, 2));
674674
tree = schematicRunner.runSchematic('migration-01', defaultOptions, tree);
675675
const e2eProject = getConfig(tree).projects['foo-e2e'];
676-
expect(e2eProject.root).toBe('apps/app1');
676+
expect(e2eProject.root).toBe('apps/app1/e2e');
677677
expect(e2eProject.sourceRoot).toBe('apps/app1/e2e');
678678
const e2eOptions = e2eProject.architect.e2e;
679679
expect(e2eOptions.builder).toEqual('@angular-devkit/build-angular:protractor');

0 commit comments

Comments
 (0)