Skip to content

Crash while close WebSocket Handler #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RezaGolriz opened this issue Jul 8, 2019 · 1 comment
Closed

Crash while close WebSocket Handler #44

RezaGolriz opened this issue Jul 8, 2019 · 1 comment
Labels

Comments

@RezaGolriz
Copy link

Describe the bug
I've find out while using WebSocket handler a crash will happen if try to stop the server. I've found out that this caused by not setting the _wsHandler to null in the HTTP Connection::closeConnection() method

@fhessel fhessel added the bug label Jul 8, 2019
@fhessel
Copy link
Owner

fhessel commented Jul 8, 2019

Thanks for the report.

WebSockets are still not fully supported, so there may be a variety of bugs.

I currently don't have the time to investigate this in-depth, but if you want a quick fix in the master, feel free to open a PR, ideally with a minimal (non-)working example to verify that easily. Sounds like you tracked down the problem quite well already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants