Skip to content

Commit f95b8ea

Browse files
martinezjaviertorvalds
authored andcommitted
Revert "venus: firmware: Correct non-pix start and end addresses"
This reverts commit a837e51, which broke probing of the venus driver, at least on the SC7180 SoC HP X2 Chromebook: qcom-venus aa00000.video-codec: Adding to iommu group 11 qcom-venus aa00000.video-codec: non legacy binding qcom-venus aa00000.video-codec: failed to reset venus core qcom-venus: probe of aa00000.video-codec failed with error -110 Matthias Kaehlcke also reported that the same change caused a regression in SC7180 and sc7280, that prevents AOSS from entering sleep mode during system suspend. So let's revert this commit for now to fix both issues. Fixes: a837e51 ("venus: firmware: Correct non-pix start and end addresses") Reported-by: Matthias Kaehlcke <[email protected]> Signed-off-by: Javier Martinez Canillas <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent a10ca09 commit f95b8ea

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/media/platform/qcom/venus/firmware.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ static void venus_reset_cpu(struct venus_core *core)
3838
writel(fw_size, wrapper_base + WRAPPER_FW_END_ADDR);
3939
writel(0, wrapper_base + WRAPPER_CPA_START_ADDR);
4040
writel(fw_size, wrapper_base + WRAPPER_CPA_END_ADDR);
41-
writel(0, wrapper_base + WRAPPER_NONPIX_START_ADDR);
42-
writel(0, wrapper_base + WRAPPER_NONPIX_END_ADDR);
41+
writel(fw_size, wrapper_base + WRAPPER_NONPIX_START_ADDR);
42+
writel(fw_size, wrapper_base + WRAPPER_NONPIX_END_ADDR);
4343

4444
if (IS_V6(core)) {
4545
/* Bring XTSS out of reset */

0 commit comments

Comments
 (0)