BUG: item_cache not cleared on DataFrame.values (pandas-dev#34999)

Author: jbrockmendel

pandas/core/frame.py

@@ -1341,6 +1341,7 @@ def to_numpy(
         array([[1, 3.0, Timestamp('2000-01-01 00:00:00')],
                [2, 4.5, Timestamp('2000-01-02 00:00:00')]], dtype=object)
         """
+        self._consolidate_inplace()
         result = self._mgr.as_array(
             transpose=self._AXIS_REVERSED, dtype=dtype, copy=copy, na_value=na_value
         )

pandas/core/generic.py

@@ -5330,6 +5330,7 @@ def values(self) -> np.ndarray:
                ['lion', 80.5, 1],
                ['monkey', nan, None]], dtype=object)
         """
+        self._consolidate_inplace()
         return self._mgr.as_array(transpose=self._AXIS_REVERSED)
 
     @property
@@ -6530,7 +6531,7 @@ def replace(
                             f"Replacement lists must match in length. "
                             f"Expecting {len(to_replace)} got {len(value)} "
                         )
-
+                    self._consolidate_inplace()
                     new_data = self._mgr.replace_list(
                         src_list=to_replace,
                         dest_list=value,

pandas/core/internals/managers.py

@@ -812,7 +812,7 @@ def as_array(
                 .values.to_numpy(dtype=dtype, na_value=na_value)
                 .reshape(self.blocks[0].shape)
             )
-        elif self._is_single_block or not self.is_mixed_type:
+        elif self._is_single_block:
             arr = np.asarray(self.blocks[0].get_values())
             if dtype:
                 arr = arr.astype(dtype, copy=False)

pandas/tests/frame/test_block_internals.py

@@ -86,9 +86,14 @@ def test_modify_values(self, float_frame):
 
         # unconsolidated
         float_frame["E"] = 7.0
+        col = float_frame["E"]
         float_frame.values[6] = 6
         assert (float_frame.values[6] == 6).all()
 
+        # check that item_cache was cleared
+        assert float_frame["E"] is not col
+        assert (col == 7).all()
+
     def test_boolean_set_uncons(self, float_frame):
         float_frame["E"] = 7.0