Skip to content

Commit 8d21e34

Browse files
authored
Merge pull request #598 from kNoAPP/knoapp-tab-s8
Fix #596 - Detect Galaxy Tab S8 as tablet
2 parents 8483ac0 + 48d930f commit 8d21e34

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

src/ua-parser.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@
373373
/////////////////////////
374374

375375
// Samsung
376-
/\b(sch-i[89]0\d|shw-m380s|sm-[pt]\w{2,4}|gt-[pn]\d{2,4}|sgh-t8[56]9|nexus 10)/i
376+
/\b(sch-i[89]0\d|shw-m380s|sm-[ptx]\w{2,4}|gt-[pn]\d{2,4}|sgh-t8[56]9|nexus 10)/i
377377
], [MODEL, [VENDOR, SAMSUNG], [TYPE, TABLET]], [
378378
/\b((?:s[cgp]h|gt|sm)-\w+|galaxy nexus)/i,
379379
/samsung[- ]([-\w]+)/i,

test/device-test.json

+9
Original file line numberDiff line numberDiff line change
@@ -1638,6 +1638,15 @@
16381638
"type": "tablet"
16391639
}
16401640
},
1641+
{
1642+
"desc": "Samsung Galaxy Tab S8",
1643+
"ua": "Mozilla/5.0 (Linux; Android 12; SM-X706B) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/103.0.5060.53 Safari/537.36",
1644+
"expect": {
1645+
"vendor": "Samsung",
1646+
"model": "SM-X706B",
1647+
"type": "tablet"
1648+
}
1649+
},
16411650
{
16421651
"desc": "Samsung Galaxy Tab S",
16431652
"ua": "Mozilla/5.0 (Linux; Android 4.4.2; SM-T700 Build/KOT49H) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/36.0.1985.135 Safari/537.36",

0 commit comments

Comments
 (0)