hot module replacement dont work with absolute publicPath

[lutzk]

when hot updating the plugin takes the current protocol + host + port + publicPath + outputFilename

https://github.com/faceyspacey/extract-css-chunks-webpack-plugin/blob/master/hotModuleReplacement.js#L3
https://github.com/faceyspacey/extract-css-chunks-webpack-plugin/blob/master/hotModuleReplacement.js#L4

so the check in https://github.com/faceyspacey/extract-css-chunks-webpack-plugin/blob/master/hotModuleReplacement.js#L13
oldChunk === newChunk is always false:

oldChunk = http://localhost:3011/dist/assets/Login
newChunk = http://localhost:3010http://localhost:3011/dist/assets/Login

when i comment out the origin it works

there could be a check for if the publicPath is an absolute one and just add the origin if its not

should i send i pr for this?

[faceyspacey]

most definitely. would appreciate the PR. thanks!

[faceyspacey]

This PR from @phyllisstein may do the trick:

#24

it just came in. I'll be reviewing these Issues fully on Monday.

[lutzk]

i checked #24
i havent tested but i think it wont fix that issue here as

the newHref is still newHref = origin + publicPath + outputFilename

[phyllisstein]

If I understand the issue correctly, I think this commit to #24 should resolve it: c86dfac. The URL constructor accepts a base URL as its second parameter; the change assumes that any publicPath that includes a protocol string is a valid base URL and passes it to the new URL, or uses window.location as the base if a protocol is missing.

[lutzk]

yes looks like it would fix my issue
but looks like if publicPath.match(/https?:/g) is false you lost the publicPath ?
i left a comment at c86dfac
thank you

[faceyspacey]

@phyllisstein PR fixing this and related issues has been merged. yarn upgrade extract-css-chunks-webpack-plugin. Thanks again @phyllisstein !!