Skip to content

fix:Improved path Settings for hotloader.js load hmr.js (#118) #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

heruiwoniou
Copy link
Contributor

Remove the exclamation point so that HMR can be handled by other loader.
e.g: babel-loader.

)

Remove the exclamation point so that HMR can be handled by other loader.
e.g: babel-loader.
@ScriptedAlchemy
Copy link
Collaborator

Hmm 🤔 does this have any ramifications for normal and existing projects? Or ‘npm link’

@heruiwoniou
Copy link
Contributor Author

heruiwoniou commented Nov 8, 2018

The general babel-loader configuration will exclude node_modules. Unless there is a special compilation requirement like that want to support IE.
So the effect doesn't spread, it only affects whether the HMR.js file itself passes through a user-defined loader

@ScriptedAlchemy
Copy link
Collaborator

Thanks for your explanation. I’ll merge this shortly

@ScriptedAlchemy ScriptedAlchemy merged commit ed10acf into faceyspacey:master Nov 9, 2018
@ScriptedAlchemy
Copy link
Collaborator

any ideas why all tests are failing? pull down master, everything files L:P

@heruiwoniou
Copy link
Contributor Author

heruiwoniou commented Nov 12, 2018

You mean the following wrong ?
SecurityError: localStorage is not available for opaque origins

I can't run this Test locally before I revise it. I tried to find out the reason, but I couldn't find the time. But I noticed that the build online passed

@ScriptedAlchemy
Copy link
Collaborator

Hmm starange. I’ll look into it again and proceed

@faceyspacey
Copy link
Owner

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants