Enable some static checking with golangci-lint and fixes a few problems found by the tool (#131)

* [redhat] Fix a couple of typo in the JSON struct tags

* [cmd2cve] Remove unused field member

* [rpm] Make ToWFN actually propagate the error

* [redhat] Remove unused field in struct

* [rbs2nvd] Remove unusued const

The UserAgent is setup as a string litteral a few lines below.

* [ci]: Enable a few linter passes with golangci-lint

* [ci] Remove the typecheck pass to work around a golangci-lint upstream bug

golangci/golangci-lint#944

* ci: Allow the go: master build to fail

Author: dlespiau

.travis.yml

@@ -1,23 +1,28 @@
 language: go
 dist: xenial
 
-go:
-- 1.13
-- 1.x
-- master
+jobs:
+  include:
+  - go: 1.13
+  - go: 1.x
+  - go: master
+  allow_failures:
+  - go: master
 
 services:
   mysql
 
 before_install:
 - sudo apt-get install -y rpm build-essential debhelper dh-make fakeroot zip
 - mysql -e 'CREATE DATABASE vulndb;'
+- curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.23.1
 
 env:
 - MYSQL_TEST_DSN=root@/vulndb
 
 script:
 - go get -v -t -u -d ./...
+- golangci-lint run ./... --disable-all -E gosimple -E govet -E ineffassign -E staticcheck -E structcheck -E varcheck
 - go test -v ./...
 
 before_deploy:

cmd/cpe2cve/config.go

@@ -59,8 +59,6 @@ type config struct {
 	// feeds
 	FeedOverrides multiString // []string
 	Feeds         map[string][]string
-
-	provider string
 }
 
 func (cfg *config) addFlags() {

cmd/rbs2nvd/rbs2nvd.go

@@ -30,8 +30,7 @@ import (
 )
 
 const (
-	baseURL   = "https://vulndb.cyberriskanalytics.com"
-	userAgent = "rbs2nvd"
+	baseURL = "https://vulndb.cyberriskanalytics.com"
 )
 
 var tokenURL = baseURL + "/oauth/token"

providers/redhat/api/client.go

@@ -37,8 +37,7 @@ const (
 // Client struct
 type Client struct {
 	client.Client
-	baseURL   string
-	userAgent string
+	baseURL string
 }
 
 // NewClient creates an object which is used to query the RedHat API

providers/redhat/schema/schema.go

@@ -29,7 +29,7 @@ type CVEList []struct {
 
 type CVE struct {
 	Name           string `json:"name,omitempty"`
-	ThreatSeverity string `json:"threat_severity,omitempty,omitempty"`
+	ThreatSeverity string `json:"threat_severity,omitempty"`
 	PublicDate     string `json:"public_date,omitempty"`
 	Bugzilla       *struct {
 		Description string `json:"description,omitempty"`
@@ -59,7 +59,7 @@ type CVE struct {
 	// the types of these are just helper types
 
 	AffectedRelease AffectedReleases `json:"affected_release,omitempty"`
-	PackageState    PackageStates    `json:"package_state,omittempty"`
+	PackageState    PackageStates    `json:"package_state,omitempty"`
 }
 
 type AffectedRelease struct {

rpm/rpm2wfn.go

@@ -22,7 +22,6 @@ import (
 
 // FromRPMName parses CPE name from RPM package name
 func ToWFN(attr *wfn.Attributes, s string) error {
-	var err error
 	pkg, err := Parse(s)
 	if err != nil {
 		return fmt.Errorf("can't get fields from %q: %v", s, err)
@@ -35,7 +34,7 @@ func ToWFN(attr *wfn.Attributes, s string) error {
 		"arch":    &pkg.Arch,
 	} {
 		if *addr, err = wfn.WFNize(*addr); err != nil {
-			err = fmt.Errorf("couldn't wfnize %s %q: %v", n, *addr, err)
+			return fmt.Errorf("couldn't wfnize %s %q: %v", n, *addr, err)
 		}
 	}